Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): migrate to Spectrum 2 #2649

Open
wants to merge 5 commits into
base: spectrum-two
Choose a base branch
from
Open

feat(tag): migrate to Spectrum 2 #2649

wants to merge 5 commits into from
+785 −669

Commits on May 14, 2024

  1. feat(tag): migrate to Spectrum 2 (CSS-618) 

    - Remove Express and Spectrum themes
- Use size M properties as default
- Add tokens for S2, including:
  - corner rounding (corner-radius-medium-size-<Tshirt size>)
  - minimum width (tag-minimum-width-<Tshirt size>)
  - maximum width (tag-maximum-width-multiplier)
  - clear button spacing (tag-label-to-clear-icon-<Tshirt size>,
    tag-edge-to-clear-icon-<Tshirt size>)
  - Adds CJK line height
- Add or adjust background colors for variants
- Remove borders (makes them transparent except for WHCM)
- Update font-weight to be medium rather than regular
- Scale avatar sizing
- Support thumbnail within Tag
- Simplify switch options by adding select menu for the visual type
  (Avatar, Icon, or Thumbnail) displayed on Tag
- Remove Avatar and Icon stories from Storybook
- Add Chromatic coverage showing multiple variants on one screen
    @rise-erpelding
    rise-erpelding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    826d0bb View commit details
    Browse the repository at this point in the history

  2. fix(tag): adjust inline spacing

    @rise-erpelding
    rise-erpelding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    07ba7cd View commit details
    Browse the repository at this point in the history

  3. fix(tag): use :last-child for label spacing 

    - also allows clear button start spacing to be set to its true value
instead of a value offsetting the label spacing and border
    @rise-erpelding
    rise-erpelding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c256c7e View commit details
    Browse the repository at this point in the history

  4. fix(tag): use :has to conditionally space visuals

    @rise-erpelding
    rise-erpelding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fc987e5 View commit details
    Browse the repository at this point in the history

  5. fix(tag): remove invalid disabled states 

    - removes disabled state from invalid variants
- removes avatar/icon/thumbnail from invalid variants
- also removes selected & disabled variant in testing preview
- "disabled" is no longer a control when invalid is true
    @rise-erpelding
    rise-erpelding committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fb7d0e3 View commit details
    Browse the repository at this point in the history