fix(popover): add highcontrast variables and additional height in docs #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2055--spectrum-css.netlify.app |
add highcontrast variables for tip make dummy spacing a bit larger to keep from hiding popover tip
mlogsdon18
force-pushed
the
css-548-popover-highcontrast
branch
from
51cd39d
to
930e29f
Compare
pfulton
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add highcontrast variables for Popover tip fill and stroke
Make dummy spacing a bit larger to keep from hiding the Popover tip on our docs site
Fixes Issue #1885
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
- [ ] View the site in WHCM using Assistiv Labs
- [ ] Observe that all Popover examples (minus the Standard - Default) have a visible tip with a white border
Regression testing
Validate:
Screenshots
Before
After
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨