Skip to content

Commit

Permalink
fix(tag): remove invalid disabled states
Browse files Browse the repository at this point in the history
- removes disabled state from invalid variants
- removes avatar/icon/thumbnail from invalid variants
- also removes selected & disabled variant in testing preview
- "disabled" is no longer a control when invalid is true
  • Loading branch information
rise-erpelding committed Apr 19, 2024
1 parent 0064d45 commit 63683bd
Showing 1 changed file with 18 additions and 26 deletions.
44 changes: 18 additions & 26 deletions components/tag/stories/tag.stories.js
Expand Up @@ -88,6 +88,7 @@ export default {
category: "State",
},
control: "boolean",
if: { arg: "isInvalid", truthy: false },
},
isSelected: {
name: "Selected",
Expand Down Expand Up @@ -170,19 +171,19 @@ const Tags = (args) => html` <div
label: "Tag with longer content that truncates",
})
)}
${when(window.isChromatic(), () =>
${when(window.isChromatic() && !args.isInvalid, () =>
Template({
...args,
visual: "Icon",
})
)}
${when(window.isChromatic(), () =>
${when(window.isChromatic() && !args.isInvalid, () =>
Template({
...args,
visual: "Avatar",
})
)}
${when(window.isChromatic(), () =>
${when(window.isChromatic() && !args.isInvalid, () =>
Template({
...args,
visual: "Thumbnail",
Expand Down Expand Up @@ -210,29 +211,20 @@ const States = (args) =>
isSelected: true,
})}
</div>
<div>
${Typography({
semantics: "detail",
size: "m",
content: ["Disabled"],
})}
${Tags({
...args,
isDisabled: true,
})}
</div>
<div>
${Typography({
semantics: "detail",
size: "m",
content: ["Disabled & Selected"],
})}
${Tags({
...args,
isDisabled: true,
isSelected: true,
})}
</div>`;
${args.isInvalid ? "" : html`
<div>
${Typography({
semantics: "detail",
size: "m",
content: ["Disabled"],
})}
${Tags({
...args,
isDisabled: true,
})}
</div>
`}
`;

const Sizes = (args) =>
html` ${["s", "m", "l"].map((size) => {
Expand Down

0 comments on commit 63683bd

Please sign in to comment.