Skip to content

Commit

Permalink
feat(picker): add support for cjk line-height
Browse files Browse the repository at this point in the history
Adds the CJK line-height token defined on the design specs.
  • Loading branch information
jawinn committed May 6, 2024
1 parent 912b701 commit 448761c
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion components/picker/index.css
Expand Up @@ -18,6 +18,7 @@ governing permissions and limitations under the License.
--spectrum-picker-font-weight: var(--spectrum-regular-font-weight);
--spectrum-picker-placeholder-font-style: var(--spectrum-default-font-style);
--spectrum-picker-line-height: var(--spectrum-line-height-100);
--spectrum-picker-line-height-cjk: var(--spectrum-cjk-line-height-100);

/* Dimensions */
--spectrum-picker-block-size: var(--spectrum-component-height-100);
Expand Down Expand Up @@ -396,7 +397,6 @@ governing permissions and limitations under the License.
font-weight: var(--mod-picker-placeholder-font-weight, var(--spectrum-picker-font-weight));
font-style: var(--mod-picker-placeholder-font-style, var(--spectrum-picker-placeholder-font-style));
transition: color var(--mod-picker-animation-duration, var(--spectrum-picker-animation-duration)) ease-in-out;

color: var(--highcontrast-picker-content-color-default, var(--mod-picker-font-color-default, var(--spectrum-picker-font-color-default)));

&:hover {
Expand All @@ -407,6 +407,13 @@ governing permissions and limitations under the License.
color: var(--highcontrast-picker-content-color-default, var(--mod-picker-font-color-active, var(--spectrum-picker-font-color-active)));
}
}

/* CJK (Chinese, Japanese, and Korean) language support */
.spectrum-Picker:lang(ja) &,
.spectrum-Picker:lang(zh) &,
.spectrum-Picker:lang(ko) & {
line-height: var(--mod-picker-line-height-cjk, var(--spectrum-picker-line-height-cjk));
}
}

/* Disclosure icon (chevron) */
Expand Down

0 comments on commit 448761c

Please sign in to comment.