Skip to content

Commit

Permalink
fix(button): restore original 1.2 line-height
Browse files Browse the repository at this point in the history
The new unitless line-height values are not going to work until the
component-top-to-text and component-bottom-to-text are also updated.
Which will come along with the new variable font update.
  • Loading branch information
jawinn committed Mar 28, 2024
1 parent e8ad19f commit 157438c
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions components/button/index.css
Expand Up @@ -25,8 +25,8 @@ governing permissions and limitations under the License.
--spectrum-button-border-radius: calc(var(--spectrum-button-height) / 2);
--spectrum-button-border-width: var(--spectrum-border-width-200);

/* @todo set line-height using font size specific line-height tokens when they are finalized. */
--spectrum-button-line-height: 1.285714;
/* @todo set line-height using font size specific line-height tokens when they are finalized along with the new variable font. */
--spectrum-button-line-height: 1.2;
--spectrum-button-font-weight: var(--spectrum-bold-font-weight);
--spectrum-button-font-size: var(--spectrum-font-size-100);

Expand All @@ -48,8 +48,6 @@ governing permissions and limitations under the License.
--spectrum-button-min-width: calc(var(--spectrum-component-height-75) * var(--spectrum-button-minimum-width-multiplier));
--spectrum-button-height: var(--spectrum-component-height-75);

/* @todo set line-height using font size specific line-height tokens when they are finalized. */
--spectrum-button-line-height: 1.333333;
--spectrum-button-font-size: var(--spectrum-font-size-75);

--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-75) - var(--spectrum-button-border-width));
Expand All @@ -70,8 +68,6 @@ governing permissions and limitations under the License.
--spectrum-button-min-width: calc(var(--spectrum-component-height-200) * var(--spectrum-button-minimum-width-multiplier));
--spectrum-button-height: var(--spectrum-component-height-200);

/* @todo set line-height using font size specific line-height tokens when they are finalized. */
--spectrum-button-line-height: 1.25;
--spectrum-button-font-size: var(--spectrum-font-size-200);

--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-200) - var(--spectrum-button-border-width));
Expand All @@ -88,8 +84,6 @@ governing permissions and limitations under the License.
--spectrum-button-min-width: calc(var(--spectrum-component-height-300) * var(--spectrum-button-minimum-width-multiplier));
--spectrum-button-height: var(--spectrum-component-height-300);

/* @todo set line-height using font size specific line-height tokens when they are finalized. */
--spectrum-button-line-height: 1.333333;
--spectrum-button-font-size: var(--spectrum-font-size-300);

--spectrum-button-edge-to-visual: calc(var(--spectrum-component-pill-edge-to-visual-300) - var(--spectrum-button-border-width));
Expand Down

0 comments on commit 157438c

Please sign in to comment.