Added support for auto-tracking personalization in Adobe Journey Optimizer. #394
+180
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwaters
reviewed
May 13, 2024
There was a problem hiding this comment.
Looks good @jonsnyder , left a few comments for you.
BTW, I have update my pr to remove trackProposition and and enhanced applyPropositions to match what you've done here.
| label: "Target element", | ||
| items: [ | ||
| { value: "selector", label: "Selector" }, | ||
| { value: "element", label: "Element" } |
There was a problem hiding this comment.
The trackProposition command did support an element or selector to be passed in, but applyPropositions does not support this. It relies on selectors only. So element should be removed here.
| }), | ||
| getInitialInstanceValues: ({ instanceSettings }) => { | ||
| const instanceValues = {}; | ||
|
|
||
| if (instanceSettings.autoTrackPropositionInteractions?.AJO) { |
There was a problem hiding this comment.
How can a customer enable autoTrackPropositionInteractions for Target if they want to in 6 months?
There was a problem hiding this comment.
They wait for a Web SDK extension update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a configuration in the extension configuration, and an option in the apply propositions command.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: