Media Collection support #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
reviewed
Dec 14, 2023
| @@ -192,7 +192,7 @@ const createExtensionManifest = ({ version }) => { | |||
| const extensionManifest = { | |||
| version, | |||
| displayName: "Adobe Experience Platform Web SDK", | |||
| name: "adobe-alloy", | |||
| name: "adobe-alloy-nina", | |||
There was a problem hiding this comment.
Don't forget to revert this before merging.
There was a problem hiding this comment.
Suggested change
| name: "adobe-alloy-nina", | |
| name: "adobe-alloy", |
package.json
Outdated
| @@ -53,7 +54,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@adobe/alloy": "^2.19.0", | |||
| "@adobe/alloy": "file:../adobe/alloy", | |||
There was a problem hiding this comment.
Don't forget to revert this before merging.
In the future, you can use the npm link command.
Suggested change
| "@adobe/alloy": "file:../adobe/alloy", | |
| "@adobe/alloy": "^2.19.0" |
There was a problem hiding this comment.
How will this work for beta? we need the beta version of alloy.js right?
|
Should we change the destination branch to |
jfkhoury
reviewed
Dec 19, 2023
jfkhoury
reviewed
Dec 19, 2023
src/lib/actions/createMediaSession/injectWrapOnBeforeMediaEvent.js
Outdated
Show resolved
Hide resolved
added 20 commits
December 20, 2023 23:00
jonsnyder
approved these changes
Apr 10, 2024
src/lib/events/createMediaAnalyticsSessionIDComplete/createMediaAnalyticsSessionIDComplete.js
Outdated
Show resolved
Hide resolved
added 22 commits
April 17, 2024 12:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding actions and events to support Media Collection in Launch.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: