Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent focus ring compilation issue in docs #6279

Merged
merged 1 commit into from Apr 29, 2024

Conversation

devongovett
Copy link
Member

Fixes an intermittent issue where focus rings appeared on mouse interaction. This seemed to appear on some PR builds and not others, and resulted in :focus-visible and :hover pseudo classes not being compiled to the .focus-ring and .is-hovered classes that we apply. The native :focus-visible pseudo class also applies on programmatic focus, which is why we see the issue.

The problem was caused by a patch we had applied to skip this compilation on the React Aria tailwind-based homepage. Since all files load this config from the same package.json file, mutating it caused unintentional changes when compiling files other than the one we were looking for. It appeared intermittent because files are compiled in a different order on each build. The fix is to clone the config and modify that instead.

@devongovett devongovett changed the title Fix intermittent focus ring compilation issue Fix intermittent focus ring compilation issue in docs Apr 27, 2024
@rspbot
Copy link

rspbot commented Apr 27, 2024

@rspbot
Copy link

rspbot commented Apr 27, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@devongovett devongovett merged commit 434b636 into main Apr 29, 2024
25 checks passed
@devongovett devongovett deleted the fix-focus-ring branch April 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants