New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand peer dep range of test utils to support RTL 14 #6264
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that we can support both https://github.com/testing-library/user-event/releases?page=3
13 vs 14 of RTL certainly has breaking change, but the actual util functions right now don't have anything specific to 14 within them (only has fireEvent and pointerEventMap, the latter of which is only a object that a user can choose to import/not import for the purpose of providing to their own |
We don't make use of any of the things which were breaking? |
NP, so the test utils right now is just the stuff in react-aria/test-utils and react-spectrum/test-util, and the only things that use stuff from testing library is https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/test-utils/src/events.ts and https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/test-utils/src/userEventMaps.ts. The first is a fireEvent util so that isn't affected by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving
I'm still worried that we can't support both once we start expanding into component specific utilities, but I'm ok with it so long as we're pre-releasing this
I agree, it might turn that the component specific utils force RTL 14 but I def want to explore supporting sub-14 RTL at the same time as 14 in my experimental branch. |
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP