Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast focus management take 2 #6223

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Toast focus management take 2 #6223

wants to merge 20 commits into from

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Apr 17, 2024

Closes

In association with #6011

βœ… Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

πŸ“ Test Instructions:

Test instructions in #6011 description

🧒 Your Project:

@rspbot
Copy link

rspbot commented Apr 23, 2024

@rspbot
Copy link

rspbot commented Apr 29, 2024

@rspbot
Copy link

rspbot commented Apr 30, 2024

@rspbot
Copy link

rspbot commented May 2, 2024

@rspbot
Copy link

rspbot commented May 3, 2024

@snowystinger snowystinger marked this pull request as ready for review May 3, 2024 18:23
@rspbot
Copy link

rspbot commented May 3, 2024

@rspbot
Copy link

rspbot commented May 8, 2024

@majornista
Copy link
Collaborator

@snowystinger With recent changes, focus is getting lost to the document.body when the top toast, the last item in the list gets removed and other toasts remain.

@rspbot
Copy link

rspbot commented May 9, 2024

@snowystinger
Copy link
Member Author

@snowystinger With recent changes, focus is getting lost to the document.body when the top toast, the last item in the list gets removed and other toasts remain.

thanks for the identification and fix, I've added a test case to cover the behavior

@rspbot
Copy link

rspbot commented May 10, 2024

@rspbot
Copy link

rspbot commented May 10, 2024

@rspbot
Copy link

rspbot commented May 10, 2024

@rspbot
Copy link

rspbot commented May 10, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-aria/toast

ToastAria

 ToastAria {
   closeButtonProps: AriaButtonProps
+  contentProps: DOMAttributes
   descriptionProps: DOMAttributes
   titleProps: DOMAttributes
   toastProps: DOMAttributes
 }

it changed:

  • useToast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants