Yarn 4 #6215

snowystinger · 2024-04-17T02:29:16Z

Closes

Comments inline below
I've left a couple peer dependency resolutions for later because they'll be solved by some other PRs we have.

I still want to replace the rest of lerna and patch-package, but that can be done in followup

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

rspbot · 2024-04-17T02:33:50Z

Build successful! 🎉

# Conflicts: # yarn.lock

rspbot · 2024-04-17T02:56:46Z

Build successful! 🎉

rspbot · 2024-04-17T04:23:36Z

Build successful! 🎉

rspbot · 2024-04-17T07:07:56Z

Build successful! 🎉

rspbot · 2024-04-17T07:08:26Z

Build successful! 🎉

rspbot · 2024-04-17T07:37:26Z

Build successful! 🎉

rspbot · 2024-04-17T07:51:46Z

Build successful! 🎉

rspbot · 2024-04-17T07:53:51Z

Build successful! 🎉

rspbot · 2024-04-19T04:44:30Z

Build successful! 🎉

rspbot · 2024-04-19T05:12:16Z

Build successful! 🎉

rspbot · 2024-04-19T05:50:42Z

Build successful! 🎉

rspbot · 2024-04-19T06:27:45Z

Build successful! 🎉

rspbot · 2024-04-19T06:33:30Z

Build successful! 🎉

rspbot · 2024-04-19T06:54:58Z

Build successful! 🎉

rspbot · 2024-04-19T07:10:28Z

Build successful! 🎉

rspbot · 2024-04-19T07:22:51Z

Build successful! 🎉

snowystinger · 2024-04-19T04:13:20Z

scripts/verdaccio.sh

+yarn config set npmPublishRegistry $registry
+yarn config set npmRegistryServer $registry
+yarn config set npmAlwaysAuth true
+yarn config set npmAuthIdent abc


we're setup for anonymous publishing to verdaccio now, so no need to log in, however, we still need these fields for some reason, even though they won't do anything

snowystinger · 2024-04-19T06:33:13Z

.circleci/config.yml

@@ -53,11 +53,6 @@ jobs:
    executor: rsp-large
    steps:
      - checkout
-      - restore_cache:


cache is checked into github right now, but we could change the caching strategy. This is the recommended one though

https://yarnpkg.com/features/caching

New recommendations will come eventually

snowystinger · 2024-04-19T06:33:45Z

.circleci/config.yml

@@ -183,6 +209,11 @@ jobs:
      - restore_cache:
          key: react-spectrum16-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}

+      - run:
+          name: Yarn version


was useful for debugging, feel like it should stay in

snowystinger · 2024-04-19T06:38:28Z

Makefile

@@ -123,7 +127,7 @@ check-examples:

 starter:
 	node scripts/extractStarter.mjs
-	cd starters/docs && yarn && yarn tsc
+	cd starters/docs && yarn --no-immutable && yarn tsc


by default on CI, yarn install is always immutable. This is important for many of our steps, however, when it comes to our sub projects with no lock files, we don't want that

note, all of them now have to have a blank yarn.lock, otherwise yarn4 will try to associate them with workspaces in our monorepo, which we don't want. this is their official stance on it and if you remove a blank one, you'll get an error message explaining you need to include a blank one

snowystinger · 2024-04-19T06:39:26Z

examples/rsp-cra-18/.yarnrc.yml

@@ -0,0 +1,3 @@
+nodeLinker: node-modules
+
+yarnPath: .yarn/releases/yarn-4.1.1.cjs


i couldn't find a way to omit this so I didn't have to copy yarn-4.1.1.cjs into every sub project

snowystinger · 2024-04-19T06:47:13Z

scripts/buildPublishedAPI.js

  let cleanPkg = {
-    name: 'rsp-website',
+    name: 'react-spectrum-monorepo',


yarn lock is apparently aware of the monorepo name and will error if it doesn't match, it doesn't really matter what we call this, so I'm just making it match

snowystinger · 2024-04-19T06:47:59Z

scripts/buildPublishedAPI.js

-        // continue
-      }
+  let packages = glob.sync('*/**/package.json', {cwd: packagesDir, ignore: ['**/node_modules/**']});
+  async function addDeps() {


this is equivalent but much faster and pulled from my tsdiffer fixes PR

snowystinger · 2024-04-19T06:58:25Z

scripts/checkPublishedDependencies.js

@@ -1,34 +0,0 @@
-const fs = require('fs');


taken care of in constraints now, might be better for plugins, undecided

snowystinger · 2024-04-19T06:59:06Z

scripts/lint-packages.js

+  // yarn enforcePublishing constraint
+  // softAssert(json.publishConfig && json.publishConfig.access === 'public', `${pkg} has missing or incorrect publishConfig`);
+  // softAssert.equal(json.license, 'Apache-2.0', `${pkg} has an incorrect license`);
+  // softAssert.deepEqual(json.repository, {type: 'git', url: 'https://github.com/adobe/react-spectrum'}, `${pkg} has incorrect or missing repository url`);


remaining checks in this file are probably good candidates for plugins

snowystinger · 2024-04-19T07:00:38Z

scripts/verdaccioPkgSize.js

@@ -11,14 +11,21 @@ function verdaccioPkgSize() {
  let verdaccioStorePath = exec('echo ~/.config/verdaccio/storage/').toString().trim();

  if (!fs.existsSync(verdaccioStorePath)) {
-    verdaccioStorePath = path.join(__dirname, '..', 'verdaccio', 'storage/');


unsure why i needed this change, @LFDanLu do you have any insight?

rspbot · 2024-04-19T08:13:24Z

Build successful! 🎉

snowystinger · 2024-04-19T09:48:08Z

Rob-bot:
Note: looks like prod docs is missing some styles, everything else is looking good

Verdaccio builds:
CRA Test App
NextJS Test App
RAC Tailwind Example
RAC Spectrum + Tailwind Example
CRA Test App Size
NextJS App Size
Publish stats
Size diff since last release
Docs
Storybook

rspbot · 2024-04-19T09:54:06Z

Build successful! 🎉

rspbot · 2024-04-19T10:04:49Z

Build successful! 🎉

rspbot · 2024-04-19T10:23:31Z

Build successful! 🎉

# Conflicts: # package.json # packages/@react-spectrum/button/package.json # packages/@react-spectrum/calendar/package.json # packages/@react-spectrum/datepicker/package.json # packages/@react-spectrum/dialog/package.json # packages/@react-spectrum/dropzone/package.json # packages/@react-spectrum/numberfield/package.json # packages/@react-spectrum/searchfield/package.json # packages/@react-spectrum/text/package.json # packages/@react-spectrum/toast/package.json # packages/dev/parcel-resolver-build/package.json # packages/dev/parcel-resolver-docs/package.json # packages/dev/parcel-transformer-docs/package.json # packages/dev/parcel-transformer-intl/package.json # packages/dev/test-utils/package.json # scripts/checkPublishedDependencies.js # scripts/lint-packages.js # yarn.lock

rspbot · 2024-04-23T02:46:28Z

Build successful! 🎉

# Conflicts: # packages/@adobe/react-spectrum/package.json # packages/@react-aria/accordion/package.json # packages/@react-aria/actiongroup/package.json # packages/@react-aria/autocomplete/package.json # packages/@react-aria/breadcrumbs/package.json # packages/@react-aria/button/package.json # packages/@react-aria/calendar/package.json # packages/@react-aria/checkbox/package.json # packages/@react-aria/color/package.json # packages/@react-aria/combobox/package.json # packages/@react-aria/datepicker/package.json # packages/@react-aria/dialog/package.json # packages/@react-aria/dnd/package.json # packages/@react-aria/focus/package.json # packages/@react-aria/form/package.json # packages/@react-aria/grid/package.json # packages/@react-aria/gridlist/package.json # packages/@react-aria/i18n/package.json # packages/@react-aria/interactions/package.json # packages/@react-aria/label/package.json # packages/@react-aria/landmark/package.json # packages/@react-aria/link/package.json # packages/@react-aria/listbox/package.json # packages/@react-aria/menu/package.json # packages/@react-aria/meter/package.json # packages/@react-aria/numberfield/package.json # packages/@react-aria/overlays/package.json # packages/@react-aria/progress/package.json # packages/@react-aria/radio/package.json # packages/@react-aria/searchfield/package.json # packages/@react-aria/select/package.json # packages/@react-aria/selection/package.json # packages/@react-aria/separator/package.json # packages/@react-aria/slider/package.json # packages/@react-aria/spinbutton/package.json # packages/@react-aria/steplist/package.json # packages/@react-aria/switch/package.json # packages/@react-aria/table/package.json # packages/@react-aria/tabs/package.json # packages/@react-aria/tag/package.json # packages/@react-aria/textfield/package.json # packages/@react-aria/toast/package.json # packages/@react-aria/toggle/package.json # packages/@react-aria/toolbar/package.json # packages/@react-aria/tooltip/package.json # packages/@react-aria/tree/package.json # packages/@react-aria/utils/package.json # packages/@react-aria/virtualizer/package.json # packages/@react-aria/visually-hidden/package.json # packages/@react-spectrum/accordion/package.json # packages/@react-spectrum/actionbar/package.json # packages/@react-spectrum/actiongroup/package.json # packages/@react-spectrum/autocomplete/package.json # packages/@react-spectrum/avatar/package.json # packages/@react-spectrum/badge/package.json # packages/@react-spectrum/breadcrumbs/package.json # packages/@react-spectrum/button/package.json # packages/@react-spectrum/buttongroup/package.json # packages/@react-spectrum/calendar/package.json # packages/@react-spectrum/card/package.json # packages/@react-spectrum/checkbox/package.json # packages/@react-spectrum/color/package.json # packages/@react-spectrum/combobox/package.json # packages/@react-spectrum/contextualhelp/package.json # packages/@react-spectrum/datepicker/package.json # packages/@react-spectrum/dialog/package.json # packages/@react-spectrum/divider/package.json # packages/@react-spectrum/dnd/package.json # packages/@react-spectrum/dropzone/package.json # packages/@react-spectrum/form/package.json # packages/@react-spectrum/icon/package.json # packages/@react-spectrum/illustratedmessage/package.json # packages/@react-spectrum/image/package.json # packages/@react-spectrum/inlinealert/package.json # packages/@react-spectrum/label/package.json # packages/@react-spectrum/labeledvalue/package.json # packages/@react-spectrum/layout/package.json # packages/@react-spectrum/link/package.json # packages/@react-spectrum/list/package.json # packages/@react-spectrum/listbox/package.json # packages/@react-spectrum/menu/package.json # packages/@react-spectrum/meter/package.json # packages/@react-spectrum/numberfield/package.json # packages/@react-spectrum/overlays/package.json # packages/@react-spectrum/picker/package.json # packages/@react-spectrum/progress/package.json # packages/@react-spectrum/provider/package.json # packages/@react-spectrum/radio/package.json # packages/@react-spectrum/searchfield/package.json # packages/@react-spectrum/slider/package.json # packages/@react-spectrum/statuslight/package.json # packages/@react-spectrum/steplist/package.json # packages/@react-spectrum/switch/package.json # packages/@react-spectrum/table/package.json # packages/@react-spectrum/tabs/package.json # packages/@react-spectrum/tag/package.json # packages/@react-spectrum/text/package.json # packages/@react-spectrum/textfield/package.json # packages/@react-spectrum/theme-dark/package.json # packages/@react-spectrum/theme-default/package.json # packages/@react-spectrum/theme-express/package.json # packages/@react-spectrum/theme-light/package.json # packages/@react-spectrum/toast/package.json # packages/@react-spectrum/tooltip/package.json # packages/@react-spectrum/tree/package.json # packages/@react-spectrum/utils/package.json # packages/@react-spectrum/view/package.json # packages/@react-spectrum/well/package.json # packages/@react-stately/calendar/package.json # packages/@react-stately/checkbox/package.json # packages/@react-stately/collections/package.json # packages/@react-stately/color/package.json # packages/@react-stately/combobox/package.json # packages/@react-stately/data/package.json # packages/@react-stately/datepicker/package.json # packages/@react-stately/dnd/package.json # packages/@react-stately/form/package.json # packages/@react-stately/grid/package.json # packages/@react-stately/layout/package.json # packages/@react-stately/list/package.json # packages/@react-stately/menu/package.json # packages/@react-stately/numberfield/package.json # packages/@react-stately/overlays/package.json # packages/@react-stately/radio/package.json # packages/@react-stately/searchfield/package.json # packages/@react-stately/select/package.json # packages/@react-stately/selection/package.json # packages/@react-stately/slider/package.json # packages/@react-stately/steplist/package.json # packages/@react-stately/table/package.json # packages/@react-stately/tabs/package.json # packages/@react-stately/toggle/package.json # packages/@react-stately/tooltip/package.json # packages/@react-stately/tree/package.json # packages/@react-stately/virtualizer/package.json # packages/@react-types/accordion/package.json # packages/@react-types/actionbar/package.json # packages/@react-types/actiongroup/package.json # packages/@react-types/autocomplete/package.json # packages/@react-types/avatar/package.json # packages/@react-types/badge/package.json # packages/@react-types/breadcrumbs/package.json # packages/@react-types/button/package.json # packages/@react-types/buttongroup/package.json # packages/@react-types/calendar/package.json # packages/@react-types/card/package.json # packages/@react-types/checkbox/package.json # packages/@react-types/color/package.json # packages/@react-types/combobox/package.json # packages/@react-types/contextualhelp/package.json # packages/@react-types/datepicker/package.json # packages/@react-types/dialog/package.json # packages/@react-types/divider/package.json # packages/@react-types/form/package.json # packages/@react-types/grid/package.json # packages/@react-types/illustratedmessage/package.json # packages/@react-types/image/package.json # packages/@react-types/label/package.json # packages/@react-types/layout/package.json # packages/@react-types/link/package.json # packages/@react-types/list/package.json # packages/@react-types/listbox/package.json # packages/@react-types/menu/package.json # packages/@react-types/meter/package.json # packages/@react-types/numberfield/package.json # packages/@react-types/overlays/package.json # packages/@react-types/progress/package.json # packages/@react-types/provider/package.json # packages/@react-types/radio/package.json # packages/@react-types/searchfield/package.json # packages/@react-types/select/package.json # packages/@react-types/slider/package.json # packages/@react-types/statuslight/package.json # packages/@react-types/switch/package.json # packages/@react-types/table/package.json # packages/@react-types/tabs/package.json # packages/@react-types/text/package.json # packages/@react-types/textfield/package.json # packages/@react-types/tooltip/package.json # packages/@react-types/view/package.json # packages/@react-types/well/package.json # packages/@spectrum-icons/color/package.json # packages/@spectrum-icons/express/package.json # packages/@spectrum-icons/illustrations/package.json # packages/@spectrum-icons/ui/package.json # packages/@spectrum-icons/workflow/package.json # packages/dev/docs/package.json # packages/dev/test-utils/package.json # packages/react-aria-components/package.json # packages/react-aria/package.json # packages/react-stately/package.json # scripts/checkPublishedDependencies.js # yarn.lock

# Conflicts: # .gitignore # package.json # yarn.lock

rspbot · 2024-05-08T08:00:33Z

Build successful! 🎉

rspbot · 2024-05-08T21:05:01Z

Build successful! 🎉

rspbot · 2024-05-08T21:05:03Z

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

snowystinger added 14 commits April 16, 2024 11:50

Yarn 4 update

c8d672d

Convert more package lints

859fe6c

fix broken constraint

d707707

enforce private and circular checks

0369b4e

fix yarn install

03e51d5

fix lock file

c86e306

fix other react installs

40eb43f

update build branch api

dbb5210

enable corepack earlier?

0385610

build branch api should not be an immutable install

ae9877c

try to make lock file mutable

d204587

use undocumented flag

cee068c

fix build step

e9eacc5

fix test esm

ef2ccaf

Merge branch 'main' into yarn-4

dd0f75f

# Conflicts: # yarn.lock

snowystinger added 2 commits April 17, 2024 12:57

check all yarn versions

b4eb9ae

fix names and fix deploy

5fa0d98

snowystinger added 2 commits April 17, 2024 16:55

get published check mostly working, will need more investigation

73598cf

turn on docs verdaccio

44f0582

try to replace lerna usage in verdaccio

4f38f54

snowystinger added 2 commits April 17, 2024 17:37

Rearrange where to publish to?

62e8dfc

run the correct command

1ed80b2

more debugging scripts

ec0a4d5

Try another location

d55c3fe

compare yarn locks

759a136

a little cleanup

fbbba2b

snowystinger commented Apr 19, 2024

View reviewed changes

snowystinger marked this pull request as ready for review April 19, 2024 07:53

snowystinger force-pushed the yarn-4 branch from 0a4fed6 to fbbba2b Compare April 19, 2024 09:43

disable extra verdaccio step

0e96872

snowystinger added 3 commits May 2, 2024 15:08

Merge branch 'main' into yarn-4

8bb3435

# Conflicts: # .gitignore # package.json # yarn.lock

fix esm test step

3c4e271

ensure that the verdaccio build still works

13c3a27

		@@ -0,0 +1,3 @@
		nodeLinker: node-modules

		yarnPath: .yarn/releases/yarn-4.1.1.cjs

Yarn 4 #6215

Are you sure you want to change the base?

Yarn 4 #6215

Conversation

snowystinger commented Apr 17, 2024 • edited

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 17, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rspbot commented Apr 19, 2024

snowystinger commented Apr 19, 2024 • edited

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 19, 2024

rspbot commented Apr 23, 2024

rspbot commented May 8, 2024

rspbot commented May 8, 2024

rspbot commented May 8, 2024

snowystinger commented Apr 17, 2024 •

edited

snowystinger commented Apr 19, 2024 •

edited