Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default when the submit button is clicked while isPending is true #6209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sookmax
Copy link
Contributor

@sookmax sookmax commented Apr 16, 2024

Closes #6197

I could've placed the logic in disablePendingProps, but thought it might be confusing for the user to see the warning message every time they click on the button while pending.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Story

http://localhost:9003/?path=/story/button--pending-spinner&providerSwitcher-express=false&strict=true

form_submit_1080.mov

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!


let isPendingProps = isPending ? {
onClick: (e) => {
if (e.currentTarget instanceof HTMLButtonElement && e.currentTarget.type === 'submit') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can always prevent the default as I imagine we'd need to do it for type === 'reset' too.

Can you think of a reason we'd allow it?

I think this is a fine place for the check, we'll eventually move pending logic into RAC, so we can always reevaluate then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Yeah I think it's safe to prevent default as long as the element is <button> since it makes sense to prevent the default behaviors for type=submit and type=reset, and type=button actually doesn't have a default behavior, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maybe by design] Button of type submit not disabled with isPending at true
2 participants