ts-strict calender fix types #6201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for #6076 cc- @snowystinger |
ishank-s
commented
Apr 14, 2024
| @@ -177,7 +184,7 @@ export function useRangeCalendarState<T extends DateValue = DateValue>(props: Ra | |||
| }; | |||
| } | |||
|
|
|||
| function makeRange(start: DateValue, end: DateValue): RangeValue<CalendarDate> { | |||
| function makeRange(start: DateValue, end: DateValue): RangeValue<CalendarDate>|null { | |||
| if (!start || !end) { | |||
| return null; | |||
There was a problem hiding this comment.
IMO null should not be used in most cases, since '?' operator of ts does not recognise it
ishank-s
commented
Apr 14, 2024
| end: convertValue(range.end, value?.end) | ||
| }); | ||
| let range = makeRange(anchorDate, previousAvailableConstrainedDate); | ||
| if (range) { |
|
Thanks for your patience. Looks like we've got some failing tests. I'll try to get some time to look into it soon if you don't figure it out before me. Thanks for having a go at this, you've already been incredibly helpful. |
|
hi @snowystinger , fixed the test but these failing jobs im not getting. reactDom.render is not a fn not sure what the issue in this one is |
|
Thank you and I apologize for a longer wait, I've had to take off for some personal reasons. I'll be back in the next week or two. |
snowystinger
merged commit 8cbc612
into
adobe:ts-strict-calendar-state
21 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: