Cache locale dict lest child hooks always re-render #6185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6184
The child hooks like
useCalendarGrid
etc. useuseLocale
to fetch their locale data.As such whenever this context value changes these hooks (and the component they are part of are forced to re-render) even if nothing else is changed. Even if the locale doesn't change as long as
I18nProvider
renders (eg. as part of a parent component update) it creates a new dict which forces a re-render.✅ Pull Request Checklist:
Added/updated unit tests and storybook for this change (for new code or code which already has tests).Updated documentation (if it already exists for this component).📝 Test Instructions:
Perform the steps in #6184 and observe the rendering of
I18nProvider
when locale doesn't change no longer causes renders inside of components using the calendar hooks.