-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook 7 #6150
Merged
Merged
Storybook 7 #6150
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
acbd030
Storybook 7
snowystinger b0d063d
storybook frame renders
snowystinger 079b253
fix story sort
snowystinger 804d9b2
install other storybook packages
snowystinger 9807703
dedupe parcel versions
snowystinger 6d08772
theoretically should work with 2.12 as macro support was released in it
snowystinger b7bf289
fix up addons
snowystinger b962254
dedupe storybook installed packages
snowystinger d93c8e3
eliminating differences
snowystinger 72e1db8
get storybook running
snowystinger da13e22
Configure canary prod build
snowystinger fe93959
fix up chromatics and tests
snowystinger d42bd40
fix engines
snowystinger 1777dd0
fix TS
snowystinger 2bbf03b
Trying to fix ?babel?
snowystinger 1eb7029
build all the docs again
snowystinger 6004325
add link to canary build of storybook
snowystinger 66112a7
Fix chromatic story
snowystinger daf68f5
fix react 16 and 17 storybooks
snowystinger c6ed446
Merge branch 'main' into sb-7
snowystinger 9d5f63f
Merge branch 'main' into sb-7
snowystinger ebe4a43
Merge branch 'main' into sb-7
snowystinger 3eba781
Merge branch 'main' into sb-7
LFDanLu e38f0d6
Merge branch 'main' into sb-7
snowystinger f9a0f9b
fix tests
snowystinger 1a2ba88
Merge branch 'main' into sb-7
snowystinger 4be672d
Merge branch 'main' into sb-7
snowystinger File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"extends": "@parcel/config-default", | ||
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."], | ||
"transformers": { | ||
"packages/*/*/intl/*.json": ["parcel-transformer-intl"], | ||
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [ | ||
"@parcel/transformer-js", | ||
"@parcel/transformer-react-refresh-wrap" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import addons from '@storybook/addons'; | ||
import {addons} from '@storybook/manager-api'; | ||
|
||
addons.setConfig({ | ||
showRoots: false, | ||
enableShortcuts: false | ||
enableShortcuts: false, | ||
sidebar: { | ||
showRoots: false, | ||
} | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"extends": "@parcel/config-default", | ||
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."], | ||
"transformers": { | ||
"packages/*/*/intl/*.json": ["parcel-transformer-intl"], | ||
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [ | ||
"@parcel/transformer-js", | ||
"@parcel/transformer-react-refresh-wrap" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import addons from '@storybook/addons'; | ||
import {addons} from '@storybook/manager-api'; | ||
|
||
addons.setConfig({ | ||
showRoots: false, | ||
enableShortcuts: false | ||
enableShortcuts: false, | ||
sidebar: { | ||
showRoots: false, | ||
} | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"extends": "@parcel/config-default", | ||
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."], | ||
"transformers": { | ||
"packages/*/*/intl/*.json": ["parcel-transformer-intl"], | ||
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [ | ||
"@parcel/transformer-js", | ||
"@parcel/transformer-react-refresh-wrap" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,26 @@ | ||
|
||
module.exports = { | ||
core: { | ||
builder: "storybook-builder-parcel", | ||
}, | ||
stories: ['../packages/**/stories/*.stories.{js,jsx,ts,tsx}'], | ||
|
||
addons: [ | ||
'@storybook/addon-actions', | ||
'@storybook/addon-a11y', | ||
'@storybook/addon-controls', | ||
'storybook-dark-mode', | ||
"@storybook/addon-actions", | ||
"@storybook/addon-a11y", | ||
"@storybook/addon-controls", | ||
"storybook-dark-mode", | ||
'./custom-addons/provider/register', | ||
'./custom-addons/descriptions/register', | ||
'./custom-addons/theme/register', | ||
'./custom-addons/strictmode/register', | ||
'./custom-addons/scrolling/register' | ||
], | ||
|
||
typescript: { | ||
check: false, | ||
reactDocgen: false | ||
}, | ||
|
||
framework: { | ||
name: "storybook-react-parcel", | ||
options: {}, | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
import addons from '@storybook/addons'; | ||
import {addons} from '@storybook/manager-api'; | ||
|
||
addons.setConfig({ | ||
showRoots: false, | ||
enableShortcuts: false | ||
enableShortcuts: false, | ||
sidebar: { | ||
showRoots: false, | ||
} | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this was intentional or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, they need to be added to our clean function as well.
I think they came from build, possibly in another branch. Either way, they need to be ignored and/or removed by clean_all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I misunderstood, I thought this was ignoring the i18n files like
useFilter
, makes sense