Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix canary tests #6144

Closed
wants to merge 14 commits into from
Closed

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Apr 3, 2024

Attempting to fix tests when running with React Canary.

Link.tsx and FocusScopeOwnerDocument.test.js fixes were taken from #6150

TODO: Fix ListBox › async loading › should fire onLoadMore if there aren't enough items to fill the ListBox calling onLoadMore 3 times instead of 1.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@reidbarber reidbarber changed the title Fix canary tests WIP: Fix canary tests Apr 3, 2024
@reidbarber
Copy link
Member Author

Closing for now, will revisit closer to React 19 release.

@reidbarber reidbarber closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants