Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submenu blog post #6143

Merged
merged 15 commits into from May 2, 2024
Merged

Submenu blog post #6143

merged 15 commits into from May 2, 2024

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Apr 3, 2024 •
edited

TOOD: link to release notes, update date for release

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

https://reactspectrum.blob.core.windows.net/reactspectrum/79139ea0f1525a911bb5c65140bb07a98888a872/docs/blog/creating-a-pointer-friendly-submenu-experience.html

🧢 Your Project:

@reidbarber reidbarber marked this pull request as ready for review April 3, 2024 15:24
@reidbarber reidbarber changed the title add Submenu blog post Submenu blog post Apr 3, 2024
@rspbot
Copy link

rspbot commented Apr 3, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 3, 2024
@rspbot
Copy link

rspbot commented Apr 5, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 5, 2024
@rspbot
Copy link

rspbot commented Apr 10, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 10, 2024
snowystinger
snowystinger previously approved these changes Apr 10, 2024
View reviewed changes
@rspbot
Copy link

rspbot commented Apr 10, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 10, 2024
snowystinger
snowystinger previously approved these changes Apr 11, 2024
View reviewed changes
@rspbot
Copy link

rspbot commented Apr 11, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 11, 2024
yihuiliao
yihuiliao previously approved these changes Apr 12, 2024
View reviewed changes
ktabors
ktabors previously approved these changes Apr 19, 2024
View reviewed changes
@rspbot
Copy link

rspbot commented Apr 22, 2024

Build successful! 🎉

devongovett
devongovett reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

packages/dev/docs/pages/blog/creating-a-pointer-friendly-submenu-experience.mdx Outdated Show resolved Hide resolved
packages/dev/docs/pages/blog/creating-a-pointer-friendly-submenu-experience.mdx Outdated Show resolved Hide resolved
packages/dev/docs/pages/blog/creating-a-pointer-friendly-submenu-experience.mdx Outdated Show resolved Hide resolved
packages/dev/docs/pages/blog/SubmenuAnimation.tsx Show resolved Hide resolved
packages/dev/docs/pages/blog/creating-a-pointer-friendly-submenu-experience.mdx Outdated Show resolved Hide resolved
@rspbot
Copy link

rspbot commented Apr 30, 2024

Build successful! 🎉

@adobe adobe deleted a comment from rspbot Apr 30, 2024
snowystinger
snowystinger previously approved these changes Apr 30, 2024
View reviewed changes
LFDanLu
LFDanLu previously approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about taking so long to take a look at this, but it looks great! Nice work

@reidbarber reidbarber dismissed stale reviews from LFDanLu and snowystinger via 9e497b4 May 1, 2024 21:12
@rspbot
Copy link

rspbot commented May 1, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 1, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@dannify dannify merged commit c9f3bbe into main May 2, 2024
25 checks passed
@dannify dannify deleted the submenu-blog-post branch May 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@dannify dannify dannify approved these changes

@ktabors ktabors ktabors left review comments

@snowystinger snowystinger snowystinger left review comments

@LFDanLu LFDanLu LFDanLu left review comments

@yihuiliao yihuiliao yihuiliao left review comments

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@reidbarber @rspbot @devongovett @ktabors @snowystinger @LFDanLu @dannify @yihuiliao