Skip to content

Commit

Permalink
Revert browserlist bump to fix native focus rings appearing on Action…
Browse files Browse the repository at this point in the history
…Button click (#6189)

* Revert browserlist bump to fix native focus rings appearing on ActionButton click

* lower caniuse-lite sub dep to fix issue

* pin to specific caniuse that passes ssr tests and doesnt cause the focus ring jank

* make it so tests dont fail on the browserlist outdated warning
  • Loading branch information
LFDanLu committed Apr 11, 2024
1 parent ab4dd5a commit 759ac41
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 32 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@
"postcss-import": "15.1.0",
"react-refresh": "0.9.0",
"remark-parse": "10.0.1",
"browserslist": "4.23.0"
"browserslist": "4.20.3",
"caniuse-lite": "1.0.30001563"
},
"@parcel/transformer-css": {
"cssModules": {
Expand Down
4 changes: 3 additions & 1 deletion scripts/setupTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ const ERROR_PATTERNS_WE_SHOULD_FIX_BUT_ALLOW = [
'`ReactDOMTestUtils.act` is deprecated in favor of `React.act`'
];

const WARNING_PATTERNS_WE_SHOULD_FIX_BUT_ALLOW = [];
const WARNING_PATTERNS_WE_SHOULD_FIX_BUT_ALLOW = [
'Browserslist: caniuse-lite is outdated'
];

function failTestOnConsoleError() {
const error = console.error;
Expand Down
48 changes: 18 additions & 30 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8529,15 +8529,16 @@ browserify-zlib@^0.2.0:
dependencies:
pako "~1.0.5"

browserslist@4.23.0, browserslist@^1.7.6, browserslist@^4.12.0, browserslist@^4.16.6, browserslist@^4.20.3, browserslist@^4.21.9, browserslist@^4.6.6:
version "4.23.0"
resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-4.23.0.tgz#8f3acc2bbe73af7213399430890f86c63a5674ab"
integrity sha512-QW8HiM1shhT2GuzkvklfjcKDiWFXHOeFCIA/huJPwHsslwcydgk7X+z2zXpEijP98UCY7HbubZt5J2Zgvf0CaQ==
browserslist@4.20.3, browserslist@^1.7.6, browserslist@^4.12.0, browserslist@^4.16.6, browserslist@^4.20.3, browserslist@^4.21.9, browserslist@^4.6.6:
version "4.20.3"
resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-4.20.3.tgz#eb7572f49ec430e054f56d52ff0ebe9be915f8bf"
integrity sha512-NBhymBQl1zM0Y5dQT/O+xiLP9/rzOIQdKM/eMJBAq7yBgaB6krIYLGejrwVYnSHZdqjscB1SPuAjHwxjvN6Wdg==
dependencies:
caniuse-lite "^1.0.30001587"
electron-to-chromium "^1.4.668"
node-releases "^2.0.14"
update-browserslist-db "^1.0.13"
caniuse-lite "^1.0.30001332"
electron-to-chromium "^1.4.118"
escalade "^3.1.1"
node-releases "^2.0.3"
picocolors "^1.0.0"

bs-recipes@1.3.4:
version "1.3.4"
Expand Down Expand Up @@ -8826,15 +8827,10 @@ caniuse-db@^1.0.30000634:
resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30001008.tgz#1691f28db0e08bf6abb5e472d8aaea392ec4a995"
integrity sha512-Fog+uREPKb/RDc0puoAqqBZB05I8wYff+TIMDkYw9Lweq7+hUEN5fNLpIaBX6AJxq4sndqPct8fYLrDUV6u4xw==

caniuse-lite@^1.0.30001109:
version "1.0.30001546"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001546.tgz"
integrity sha512-zvtSJwuQFpewSyRrI3AsftF6rM0X80mZkChIt1spBGEvRglCrjTniXvinc8JKRoqTwXAgvqTImaN9igfSMtUBw==

caniuse-lite@^1.0.30001587:
version "1.0.30001603"
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001603.tgz#605046a5bdc95ba4a92496d67e062522dce43381"
integrity sha512-iL2iSS0eDILMb9n5yKQoTBim9jMZ0Yrk8g0N9K7UzYyWnfIKzXBZD5ngpM37ZcL/cv0Mli8XtVMRYMQAfFpi5Q==
caniuse-lite@1.0.30001563, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001332:
version "1.0.30001563"
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001563.tgz#aa68a64188903e98f36eb9c56e48fba0c1fe2a32"
integrity sha512-na2WUmOxnwIZtwnFI2CZ/3er0wdNzU7hN+cPYz/z2ajHThnkWjNBOpEPP4n+4r2WPM847JaMotaJE3bnfzjyKw==

capture-stack-trace@^1.0.0:
version "1.0.1"
Expand Down Expand Up @@ -10947,10 +10943,10 @@ ee-first@1.1.1:
resolved "https://registry.yarnpkg.com/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d"
integrity sha1-WQxhFWsK4vTwJVcyoViyZrxWsh0=

electron-to-chromium@^1.4.668:
version "1.4.722"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.722.tgz#99ae3484c5fc0f387d39ad98d77e1f259b9f4074"
integrity sha512-5nLE0TWFFpZ80Crhtp4pIp8LXCztjYX41yUcV6b+bKR2PqzjskTMOOlBi1VjBHlvHwS+4gar7kNKOrsbsewEZQ==
electron-to-chromium@^1.4.118:
version "1.4.733"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.733.tgz#708d51ce01a7ed3b401d5ced85e9f5d504fd4217"
integrity sha512-gUI9nhI2iBGF0OaYYLKOaOtliFMl+Bt1rY7VmEjwxOxqoYLub/D9xmduPEhbw2imE6gYkJKhIE5it+KE2ulVxQ==

element-resize-detector@^1.2.2:
version "1.2.4"
Expand Down Expand Up @@ -18784,7 +18780,7 @@ node-preload@^0.2.1:
dependencies:
process-on-spawn "^1.0.0"

node-releases@^2.0.14:
node-releases@^2.0.3:
version "2.0.14"
resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-2.0.14.tgz#2ffb053bceb8b2be8495ece1ab6ce600c4461b0b"
integrity sha512-y10wOWt8yZpqXmOgRo77WaHEmhYQYGNA6y421PKsKYWEK8aW+cqAphborZDhqfyKrbZEN92CN1X2KbafY2s7Yw==
Expand Down Expand Up @@ -24632,14 +24628,6 @@ upath@^1.1.1:
resolved "https://registry.yarnpkg.com/upath/-/upath-1.2.0.tgz#8f66dbcd55a883acdae4408af8b035a5044c1894"
integrity sha512-aZwGpamFO61g3OlfT7OQCHqhGnW43ieH9WZeP7QxN/G/jS4jfqUkZxoryvJgVPEcrl5NL/ggHsSmLMHuH64Lhg==

update-browserslist-db@^1.0.13:
version "1.0.13"
resolved "https://registry.yarnpkg.com/update-browserslist-db/-/update-browserslist-db-1.0.13.tgz#3c5e4f5c083661bd38ef64b6328c26ed6c8248c4"
integrity sha512-xebP81SNcPuNpPP3uzeW1NYXxI3rxyJzF3pD6sH4jE7o/IX+WtSpwnVU+qIsDPyk0d3hmFQ7mjqc6AtV604hbg==
dependencies:
escalade "^3.1.1"
picocolors "^1.0.0"

update-notifier@^2.5.0:
version "2.5.0"
resolved "https://registry.yarnpkg.com/update-notifier/-/update-notifier-2.5.0.tgz#d0744593e13f161e406acb1d9408b72cad08aff6"
Expand Down

1 comment on commit 759ac41

@rspbot
Copy link

@rspbot rspbot commented on 759ac41 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.