-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor logic to prevent breaking changes in useToastState (#6270)
* Refactor logic to prevent breaking changes in useToastState * added more tests and fixing a bug they caught * Fixed the other bug found by new tests * fix toast visual insertion so it inserts at the bottom * remove uneeded key and handle case where a user just calls remove * tentative change to readd exiting to toasts that are shifted out of the visibleToast list due to a higher priority toast being added * fix so that a toast that is removed but not closed doesnt get removed from the queue this mimics the exitAnimation call to close that RSP toast does * add test to make sure order of toast doesnt change on close --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Kyle Taborski <ktabors@yahoo.com> Co-authored-by: Devon Govett <devongovett@gmail.com>
- Loading branch information
1 parent
04df93f
commit 1bd538f
Showing
3 changed files
with
235 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bd538f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verdaccio builds:
CRA Test App
NextJS Test App
RAC Tailwind Example
RAC Spectrum + Tailwind Example
CRA Test App Size
NextJS App Size
Publish stats
Size diff since last release
Docs
Storybook