Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type error causing build failure in the destination package #270

Merged
merged 1 commit into from Apr 29, 2024

Conversation

mia-mifeng
Copy link
Collaborator

@mia-mifeng mia-mifeng commented Apr 27, 2024

Description

This PR fixes the error A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type. described in the issue #272. See "possible solution" in the issue for more details.

Related Issue

#272

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

sonarcloud bot commented Apr 27, 2024

Copy link

@mia-mifeng mia-mifeng marked this pull request as ready for review April 29, 2024 17:16
@mia-mifeng mia-mifeng merged commit d6f388a into main Apr 29, 2024
5 checks passed
@mia-mifeng mia-mifeng deleted the mif/tsconfig-fix branch April 29, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants