New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An 334305/highlight by #266
Conversation
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-266 |
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-266 |
const scatterHoverAreas = await findAllMarksByGroupName(chart, 'scatter0_voronoi'); | ||
await hoverNthElement(scatterHoverAreas, 0); | ||
|
||
// highlighted points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love these helpful comments!! 💯
@@ -37,6 +38,13 @@ interface LineData extends Datum { | |||
category?: string; | |||
} | |||
|
|||
interface MarioData extends Datum { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray for fun data!!! 🚀 🥳
(data.transform?.[0] as FilterTransform).expr.includes(`indexof(pluck(data('line0_highlightedData')`) | ||
).toBe(true); | ||
}); | ||
test('should include high resolution data if not a widnow method', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I widnow (would know) if this included a high rez data object, I mean it's as clear as the glass of the window
I'm looking at!
(aka widnow => window --- next PR)
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-266 |
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-266 |
Quality Gate passedIssues Measures |
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-266 |
Description
Support highlightBy for scatter
Related Issue
#238
Stories
ChartTooltip > HighlightBy > ScatterChart
Screenshots (if appropriate):
Screen.Recording.2024-04-25.at.12.06.05.PM.mov
Types of changes
Checklist: