Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An 334305/highlight by #266

Merged
merged 6 commits into from May 2, 2024
Merged

An 334305/highlight by #266

merged 6 commits into from May 2, 2024

Conversation

marshallpete
Copy link
Member

@marshallpete marshallpete commented Apr 25, 2024

Description

Support highlightBy for scatter

Related Issue

#238

Stories

ChartTooltip > HighlightBy > ScatterChart

Screenshots (if appropriate):

Screen.Recording.2024-04-25.at.12.06.05.PM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

Copy link

const scatterHoverAreas = await findAllMarksByGroupName(chart, 'scatter0_voronoi');
await hoverNthElement(scatterHoverAreas, 0);

// highlighted points
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these helpful comments!! 💯

@@ -37,6 +38,13 @@ interface LineData extends Datum {
category?: string;
}

interface MarioData extends Datum {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray for fun data!!! 🚀 🥳

(data.transform?.[0] as FilterTransform).expr.includes(`indexof(pluck(data('line0_highlightedData')`)
).toBe(true);
});
test('should include high resolution data if not a widnow method', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I widnow (would know) if this included a high rez data object, I mean it's as clear as the glass of the window I'm looking at!

(aka widnow => window --- next PR)

Bryant-Curtis
Bryant-Curtis previously approved these changes Apr 25, 2024
Copy link

Copy link

github-actions bot commented May 2, 2024

Copy link

sonarcloud bot commented May 2, 2024

Copy link

github-actions bot commented May 2, 2024

@marshallpete marshallpete merged commit 254f377 into main May 2, 2024
5 checks passed
@marshallpete marshallpete deleted the an-334305/highlightBy branch May 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants