feat: add highlightBy functionality to ChartTooltip #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallpete
commented
Apr 18, 2024
| @@ -45,6 +45,7 @@ const defaultAreaProps: AreaSpecProps = { | |||
| color: DEFAULT_COLOR, | |||
| dimension: DEFAULT_TIME_DIMENSION, | |||
| index: 0, | |||
| markType: 'area', | |||
There was a problem hiding this comment.
I added a property markType to bar, area, line, scatter and donut. This is helpful for chart tooltip since it could be added to any of these. With the markType prop, chart tooltip can be setup correctly for the correct mark type.
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-255 |
|
There are a handful of prettier updates. Prettier broke for a little while so some things slipped in. |
olsonjb
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
highlightByprop to<ChartTooltip />. This allows you to define the highlight behavior on hover of an item.To simplify the PR review process. This only. includes all the functionality that will be used by the different mark types. Separate PRs will be submitted for each mark type (line, area, bar, scatter, donut).
Related Issue
#238
Motivation and Context
Often users want to highlight a group of points or marks when hovering over the chart.
Types of changes
Checklist: