Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-217 Support datetime data properly for Line & Bar & Area charts #245

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

mia-mifeng
Copy link
Collaborator

@mia-mifeng mia-mifeng commented Apr 15, 2024

Description

This PR fixes the issue where some general datetime formats were not supported for certain charts. The solution is to add a transform to the generated vega spec to convert the datetime data to "Date" which vega can interpret. More details in this comment.

Related Issue

#217

Motivation and Context

See more details in #217

How Has This Been Tested?

  • storybook: Line -> LineWithUTCDatetimeFormat
  • unit test

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mia-mifeng mia-mifeng changed the title Issue-217 datetime data Issue-217 Support datetime data properly for Line & Bar & Area charts Apr 15, 2024
Copy link

@mia-mifeng mia-mifeng marked this pull request as ready for review April 16, 2024 20:30
Copy link

Copy link

sonarcloud bot commented Apr 16, 2024

Copy link

@marshallpete marshallpete merged commit 6e85045 into main Apr 16, 2024
5 checks passed
@marshallpete marshallpete deleted the mif/issue-217-datetime-data branch April 16, 2024 21:17
@matthewdeutsch matthewdeutsch linked an issue May 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support datetime data properly for Line & Bar & Area charts
2 participants