Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart animations to Area, Bar, Line, and (opacity-only) Scatter #224

Open
wants to merge 121 commits into
base: byu-team-animations
Choose a base branch
from

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    ab5e3f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c421d9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e09a53 View commit details
    Browse the repository at this point in the history
  4. fix: remove debug

    gideontonkinson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b8f65df View commit details
    Browse the repository at this point in the history
  5. feat: add timer value to signals (#127)

    * chore: add timer value to signals
    
    * fix: remove debug from chart.story.tsx
    
    * chore: add tests for timer signal
    
    * fix: remove debug
    gideontonkinson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    30a0af4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    84b075f View commit details
    Browse the repository at this point in the history
  2. fix: fix broken test

    gideontonkinson committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    20288a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. fix: remove debug

    gideontonkinson committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    41d7141 View commit details
    Browse the repository at this point in the history
  2. Gtonkinson/animations (#132)

    * chore: add timer value to signals
    
    * fix: remove debug from chart.story.tsx
    
    * chore: add tests for timer signal
    
    * fix: remove debug
    
    * feat: add previous data table to data
    
    * fix: fix broken test
    
    * fix: remove debug
    gideontonkinson committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3b09115 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge remote to local

    Judd2000 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c8fc4df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bcd803 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    4876f79 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    b4405e3 View commit details
    Browse the repository at this point in the history
  2. Animations remove todo

    Judd2000 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d36b674 View commit details
    Browse the repository at this point in the history
  3. Animations remove todo

    Judd2000 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    df8c5fb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c1fc3d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    a7897f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    c349cd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    496e62f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    248d2d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Animations add dodged bar-specific animations as well as hide labels …

    …until animations finished
    Judd2000 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    43a29ff View commit details
    Browse the repository at this point in the history
  2. Animations lint fixes

    Judd2000 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d96361f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e736d42 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge pull request #153 from adobe/nathaniel-judd/byu-team/animations

    Nathaniel judd/byu team/animations
    Judd2000 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a3c56d9 View commit details
    Browse the repository at this point in the history
  2. Add animation easing

    jacob-hart committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    00ec648 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #160 from adobe/jacob-hart/byu-team/easing

    Add animation easing
    Judd2000 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e7bcc86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    af1a1e6 View commit details
    Browse the repository at this point in the history
  5. Merge remote to local

    Judd2000 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    56b39a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6159cad View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    644ec12 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. animation storybook

    gideontonkinson committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    53c2c06 View commit details
    Browse the repository at this point in the history
  2. merge in changes

    gideontonkinson committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    560d4e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    7702d7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18bba7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb885e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Add animation spec backwards compatibility with existing tests (#169)

    * Remove console.warn
    
    * Fix areaUtil tests
    
    * Fix areaSpecBuilder tests
    
    * Update linePointUtils to avoid creating unnecessary keys
    
    * Fix lineMarkUtils tests
    
    * Fix lineSpecBuilder tests
    
    * Fix bar tests
    
    * Fix metricRangeUtils tests
    jacob-hart committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4b849ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    956e421 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8174613 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5cc4c2a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9832018 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e56701b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c7cc0a1 View commit details
    Browse the repository at this point in the history
  8. feat: add more tests

    gideontonkinson committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    83bad13 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    abe7efd View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. merge in main branch

    gideontonkinson committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    14285ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acb855e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1aa7490 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    9329ade View commit details
    Browse the repository at this point in the history
  2. Animations re-add semicolon

    Judd2000 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cbea9a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bf86f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0fca769 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    5c53a88 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Configuration menu
    Copy the full SHA
    8905b7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7174ba9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    628ee82 View commit details
    Browse the repository at this point in the history
  4. Animations added interface to allow certain tests to override animati…

    …ons property in trellisbar. A similar approach can be used in other tests
    Judd2000 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    151cbe2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    b7bcc62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2f9e66 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c7c546 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    42ece8e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    e785232 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Change animation duration (#198)

    Change animation duration and use constants instead of magic numbers
    jacob-hart committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    6aa151e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. njudd/animations added animateFromZero state variable to RscChart and…

    … implemented it across specbuilders, set it to false when chart popover is changed and set to false
    Judd2000 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b6a0b91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23345a7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa2e00c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge pull request #207 from adobe/njudd/byu-team/animations

    Njudd/byu team/animations - fixes to animation function when popover pressed, fixing trellis bar and other tests broken by animations
    Judd2000 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    e217127 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Configuration menu
    Copy the full SHA
    fc12bef View commit details
    Browse the repository at this point in the history
  2. Animations made area and line charts have tooltips and highlight mark…

    …s hidden until animations are done
    Judd2000 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c3ee2b8 View commit details
    Browse the repository at this point in the history
  3. Removed unused vars

    Judd2000 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    78d712a View commit details
    Browse the repository at this point in the history
  4. Minor build fixes

    Judd2000 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    46b5251 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Animations made area and line charts have tooltips and highlight mark… (

    #213)
    
    Animations made area and line charts have tooltips and highlight marks hidden until animations are done
    Judd2000 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    44cac56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05d1de3 View commit details
    Browse the repository at this point in the history
  3. Add Opacity animation functionality to line, bar, scatter, trendline,…

    … legends, and area charts (#223)
    agardn87 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f15f413 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Gtonkinson/animations (#225)

    * Add signals and scales for opacity animations
    
    These changes add signals and scales for opcity animations for the barSpecBuilder.
    As part of these changes, lengendSpecBuilder was also changed to update an existing signal.
    
    * Remove console.warn
    
    * Fix areaUtil tests
    
    * Fix areaSpecBuilder tests
    
    * Update linePointUtils to avoid creating unnecessary keys
    
    * Fix lineMarkUtils tests
    
    * Fix lineSpecBuilder tests
    
    * Fix bar tests
    
    * Fix metricRangeUtils tests
    
    * Add opacity animations to all bar charts
    
    This change allows for opacity animations to all bar charts with a
    tooltip or a popover. Animations must be enabled on the chart level
    for the animations to appear.
    
    * Refactor code to match style of existing code
    
    * Add opacity animation functionality to line charts.
    
    With this change, all line charts with a tooltip or popover will
    animate on hover. Visiually, the animation eases the opacity in and out
    on non-hovered lines.
    
    * Add opacity animations to area and trendline.
    
    With these changes, and upon animation enablement, opacity animations
    are present with an area, line, and bar chart that has a tooltip, popover,
    or trendline.
    
    * Refactor mouseover function to reduce code for opacity animations
    
    * Add opacity animations to legend symbols.
    
    This change includes logic that adds opacity animation to legend
    symbols if the current spec has the opacity animation signals for
    line, bar, or area charts. This change also has a couple added checks
    for interactive children.
    
    * Integrate opacity animations with new changes on main
    
    * Remove unecessary debug settings
    
    * Fix legend hover opacity animations
    
    * Add TODO comments for tracking and testing purposes
    
    * Change opacity animation default
    
    * Change opacity animation gates to expressly check for false
    
    * chore: upgrade storybook to v8
    
    * fix: add testing for animations
    
    * testing for opacity
    
    * fix: add testing for opacity, still need to add opacity story
    
    * fix: add testing to test opacity
    
    * fix opacity stories
    
    * remove readded code
    
    * fix odd indenting
    
    * remove unused def'
    
    ---------
    
    Co-authored-by: Adam <adamgrdnr@gmail.com>
    Co-authored-by: Jacob <jacobhart1227@gmail.com>
    Co-authored-by: Marshall Peterson <marshall.w.peterson@gmail.com>
    Co-authored-by: tanugarg04 <61331804+tanugarg04@users.noreply.github.com>
    5 people committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7fdca27 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Animations-3 fixed issues with stacked bars and stacked areas - added…

    … stacked area story to Animations
    Judd2000 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2a9de92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b68afae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    04128b1 View commit details
    Browse the repository at this point in the history
  4. Animations fix utils

    Judd2000 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2b75a2b View commit details
    Browse the repository at this point in the history
  5. Merge pull request #228 from adobe/njudd/byu-team/animations-3

    Njudd/byu team/animations 3
    Judd2000 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f001052 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7fc39fa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    03c4ebe View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. fix: tests

    gideontonkinson committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d34b64c View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    f255a21 View commit details
    Browse the repository at this point in the history
  2. Animation more code cleanup

    Judd2000 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5aa58af View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Animations made ANIMATION_FUNCTION constant that is assigned to EASE_…

    …OUT to reduce code ripples when we want to change it
    Judd2000 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ce160d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52e5826 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6a7f1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1ac8ba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6c9cb9a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    67a5778 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    57a120f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    97c8c6b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7365302 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7927719 View commit details
    Browse the repository at this point in the history
  11. Animatioins moved usePreviousChartData out to the react hooks directo…

    …ry - removed generics in favor of ChartData[]
    Judd2000 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f87e38c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    579dcf9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    dabe3e9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2923b15 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    31dc879 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    51e4b18 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    1a64554 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bd61d6 View commit details
    Browse the repository at this point in the history
  3. Use mark id for animations

    jacob-hart committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c2e20e3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1488446 View commit details
    Browse the repository at this point in the history
  5. Remove unused imports

    jacob-hart committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a5e9caf View commit details
    Browse the repository at this point in the history
  6. add more testing

    gideontonkinson committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a1bebf4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ede3c17 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0d82e8f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fc9273f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2771e35 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2f7e3a8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fc1ce4c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    af6f684 View commit details
    Browse the repository at this point in the history
  14. remove warns

    gideontonkinson committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6546d0c View commit details
    Browse the repository at this point in the history
  15. remove more todos

    gideontonkinson committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a1b32db View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f695e8c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    00b1d03 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    573305b View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    05db649 View commit details
    Browse the repository at this point in the history
  20. Animation set SharedChartProps animations to optional, added necessar…

    …y check to rscChart (even though it will always be defined by that point)
    Judd2000 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d9aa043 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    39b7a41 View commit details
    Browse the repository at this point in the history