Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-56 - Drag and drop #125

Merged
merged 2 commits into from
May 6, 2024
Merged

GH-56 - Drag and drop #125

merged 2 commits into from
May 6, 2024

Conversation

auniverseaway
Copy link
Member

@auniverseaway auniverseaway commented May 6, 2024

  • Support uploading depths of up to 1000 folders deep
  • Supports singular uploads
  • Converts all spaces into dashes
  • Filters out unsupported file types and extensions
  • Supports all major browsers: Chrome, Safari, Firefox, iOS Safari

Resolves: GH-56

How Has This Been Tested?

  • Chrome (Mac & Windows)
  • Safari (Mac & iOS)
  • Firefox (Mac & Windows)
  • Chromium (Linux)

How to test

Drag any supported file type (or folders with files) to here:
https://dnd--da-live--adobe.aem.page/#/aemsites/da-block-collection/drafts/dnd

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Release notes

  • Supports singular uploads
  • Support uploading folder depths of up to 1000 deep
  • Converts all spaces into dashes
  • Filters out unsupported file types and extensions
  • Supports all major browsers: Chrome, Safari, Firefox, iOS Safari
Screenshot 2024-05-06 at 10 04 54 AM

* Support uploading depths of up to 1000 folders deep
* Filters out unsupported file types and extensions
* Supports all major browsers: Chrome, Safari, Firefox, iOS Safari
* Supports singular uploads

Resolves: GH-56
Copy link

aem-code-sync bot commented May 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 6, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@auniverseaway auniverseaway merged commit 78aab3a into main May 6, 2024
3 of 5 checks passed
@auniverseaway auniverseaway deleted the dnd branch May 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag to upload
2 participants