Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Alt Text #102

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Image Alt Text #102

merged 9 commits into from
Apr 24, 2024

Conversation

chrischrischris
Copy link
Contributor

@chrischrischris chrischrischris commented Apr 9, 2024

Description

Add ability to set Alt text on an image.

Also:

  • Add saveOnClose option to openPrompt - this will save any changes done in the palette when a user either clicks the palette icon again or when they change the cursor position in the document.
  • Set the link palette to saveOnClose, also set it to close when clicking the palette icon when it's open.

Related Issue

#45

Release notes

  1. Adds image alt-text support.
  2. Contextually available when image is selected.

Demo: https://ccc-alt-text--da-live--adobe.hlx.page/edit#/chrischrischris/da-milo-college/demo

Screenshot 2024-04-23 at 6 52 27 PM

Copy link

aem-code-sync bot commented Apr 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

auniverseaway
auniverseaway previously approved these changes Apr 10, 2024
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works for now. My one small nit is that I think the icon should be 100% hidden if it cannot be used. The toolbar is going to get bigger over time and this would help cut down on size to make icons more contextual to the available tasks.

I used CSS :has() to hide assets. It's not 100% ideal, but it should be fine for now.

.ProseMirror-menuitem:has(.open-assets.ProseMirror-menu-disabled) {
  display: none;
}

Copy link

aem-code-sync bot commented Apr 10, 2024

Page Scores Audits Google
/edit PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@auniverseaway auniverseaway merged commit c9fa5c0 into main Apr 24, 2024
4 of 5 checks passed
@auniverseaway auniverseaway deleted the ccc-alt-text branch April 24, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants