-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Alt Text #102
Image Alt Text #102
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works for now. My one small nit is that I think the icon should be 100% hidden if it cannot be used. The toolbar is going to get bigger over time and this would help cut down on size to make icons more contextual to the available tasks.
I used CSS :has()
to hide assets. It's not 100% ideal, but it should be fine for now.
.ProseMirror-menuitem:has(.open-assets.ProseMirror-menu-disabled) {
display: none;
}
|
Description
Add ability to set Alt text on an image.
Also:
saveOnClose
option toopenPrompt
- this will save any changes done in the palette when a user either clicks the palette icon again or when they change the cursor position in the document.Related Issue
#45
Release notes
Demo: https://ccc-alt-text--da-live--adobe.hlx.page/edit#/chrischrischris/da-milo-college/demo