Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-96 - Rename files and folders #34

Merged
merged 2 commits into from
May 1, 2024

Conversation

sukamat
Copy link
Contributor

@sukamat sukamat commented Apr 27, 2024

Description

API to rename files and folders.

Related Issue

adobe/da-live#96

How Has This Been Tested?

  • Tested locally with curl
  • Tested in combination with da-live

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Release notes

  1. Ability to rename files & folders.
  2. Folder rename will perform a deep traversal to ensure all keys change.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (46afff5) to head (8c40469).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files          13       13           
  Lines         837      837           
=======================================
  Hits          510      510           
  Misses        327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. My only reservation here is that a rename for a deep folder structure is going to take a long time. I think we'll need some UX affordances to handle this.

@sukamat
Copy link
Contributor Author

sukamat commented Apr 30, 2024

@auniverseaway Correct. For the time being, a loader in the UI has been added to cater that scenario adobe/da-live#96

@auniverseaway auniverseaway merged commit 8eabefd into adobe:main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants