Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Accessability): Add button role to table header interactive element #347

Merged
merged 7 commits into from
May 15, 2024
Merged

fix(Accessability): Add button role to table header interactive element #347

merged 7 commits into from
May 15, 2024

Commits on Apr 24, 2024

  1. added role button to the required elements

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c97143b View commit details
    Browse the repository at this point in the history

  2. added role button to the required elements

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5ce5e3a View commit details
    Browse the repository at this point in the history

  3. added null check

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5eeb8fb View commit details
    Browse the repository at this point in the history

  4. remove aria sort attribute

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    928e0de View commit details
    Browse the repository at this point in the history

  5. removed code

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5575b20 View commit details
    Browse the repository at this point in the history

  6. restore code

    @StoianLucian
    StoianLucian committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4a84b51 View commit details
    Browse the repository at this point in the history

  7. sticky should not move role=columnheader to header cell content 

    - Column header cells should always have role="columnheader".
- Sortable cell content should have role="button" and tabindex="0".
- Sortable column header cells should have aria-sort attribute, regardless of whether or not the table header row is sticky.
    @majornista
    majornista committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6bddece View commit details
    Browse the repository at this point in the history