Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SITES-3057 Accessibility) - Decorative image has non-empty alt attribute. #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(SITES-3057 Accessibility) - Decorative image has non-empty alt attribute. #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions coral-component-card/src/scripts/CardProperty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ const CardProperty = Decorator(class extends BaseComponent(HTMLElement) {

// removes the icon element from the DOM since there is no valid icon. this causes the content to have the
// correct styling

if(this._elements.icon.icon === 'globeRemove') {
this._elements.icon.removeAttribute('aria-label');
this._elements.icon.setAttribute("alt", '');
}

if (this.icon === '') {
this._elements.icon.remove();
} else if (!this._elements.icon.parentNode) {
Expand Down