Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Text should not be marked as a heading #334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mariang-ens
Copy link
Contributor

JIRA Ticket: https://jira.corp.adobe.com/browse/SITES-11021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mariang-ens mariang-ens changed the title SITES-11021 button text is no longer marked as heading fix: Text should not be marked as a heading Apr 23, 2024
@@ -532,6 +532,13 @@ const Dialog = Decorator(class extends BaseOverlay(BaseComponent(HTMLElement)) {
}

this.variant = this.variant;

if (header.getAttribute('class', 'cq-dialog-actions')) {
var headerChild = document.getElementsByClassName('cq-dialog-actions')[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use let or const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants