Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SITES-16796) Image Missing Alt Text #328

Closed
wants to merge 3 commits into from
Closed

fix(SITES-16796) Image Missing Alt Text #328

wants to merge 3 commits into from

Conversation

ens84646
Copy link
Contributor

Jira ticket: https://jira.corp.adobe.com/browse/SITES-16796

Description

Changing aria-label to menubar-item title and adding alt to coral-icon.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@StoianLucian StoianLucian changed the title SITES-16796: Image Missing Alt Text fix(SITES-16796) Image Missing Alt Text Mar 18, 2024
@StoianLucian
Copy link
Contributor

moved changes to #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoianLucian StoianLucian StoianLucian left review comments

@cbogdan0707 cbogdan0707 cbogdan0707 approved these changes

@Pareesh Pareesh Pareesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ens84646 @StoianLucian @cbogdan0707 @Pareesh @TeodorEns