Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Accessibility) - Text alternative does not present same info as image. #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Accessibility) - Text alternative does not present same info as image. #325

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5897ab1
Sync icon aria-label with coral-card-property title.
TeodorEns Nov 16, 2023
e21e420
added null check
StoianLucian Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions coral-component-card/src/scripts/CardProperty.js
View file
Open in desktop
Expand Up @@ -163,6 +163,10 @@ const CardProperty = Decorator(class extends BaseComponent(HTMLElement) {

// Assign the content zones, moving them into place in the process
this.content = content;

// Adjusting icon aria-label attribute as per coral-card-property title attribute
const iconParentTitle = this._elements.icon.parentNode.getAttribute('title');
StoianLucian marked this conversation as resolved.
Show resolved Hide resolved
this._elements.icon.setAttribute('aria-label', iconParentTitle);
}
});

Expand Down