Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-10934: Color alone is used to convey information. #319

Closed
wants to merge 1 commit into from
Closed

SITES-10934: Color alone is used to convey information. #319

wants to merge 1 commit into from

Conversation

stefan-dragomir
Copy link

petcud
petcud approved these changes Nov 8, 2023
View reviewed changes
Copy link

@petcud petcud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the curly braces.
For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

@ens84646
Copy link
Contributor

ens84646 commented Nov 9, 2023

Please fix the curly braces. For the complexity warning, if you cannot simplify the complexity, and it's code that wasn't introduced by you, it might generate a code smell report but should be fine to merge.

@petcud check warnings not related to the actual change, should we resolve this reports for every PR created as long as it were not generated by this PR?

@mariang-ens
Copy link
Contributor

Opened a new PR with some fixes to the curly braces here

@TeodorEns
Copy link
Contributor

Please close this as this implementation was moved to #336

@StoianLucian
Copy link
Contributor

implementation was moved to #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petcud petcud petcud approved these changes

@ens84646 ens84646 ens84646 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stefan-dragomir @ens84646 @mariang-ens @TeodorEns @StoianLucian @petcud