Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Accessibility): on column item selection screen reader should read the newly added preview column content #298

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TudorSMR
Copy link
Contributor

@TudorSMR TudorSMR commented May 29, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this behavior?

@Pareesh
Copy link
Collaborator

Pareesh commented Jul 12, 2023

@TudorSMR please check the failing build as well.

@Pareesh Pareesh changed the title fix(ASSETS-17252): Informative (static) content is not readable by a screen reader fix(Accessibility): On selection screen reader should read the newly added preview column content Jul 19, 2023
@Pareesh Pareesh changed the title fix(Accessibility): On selection screen reader should read the newly added preview column content fix(Accessibility): on column item selection screen reader should read the newly added preview column content Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants