Fixed an issue where Web SDK failed to read cross domain identities when there were multiple adobe_mc query string parameters #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
approved these changes
Jan 2, 2024
jfkhoury
reviewed
Jan 2, 2024
| if (queryStringValue === undefined) { | ||
| return; | ||
| } | ||
| if (Array.isArray(queryStringValue)) { |
There was a problem hiding this comment.
Should we add a length check as well? Or will queryStringValue only be of type Array if it contains multiple adobe_mc?
There was a problem hiding this comment.
Yes.
0 instances - undefined
1 instance - string
2 or more - array
jonsnyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple adobe_mc parameters were specified, the URL parsing function returns an array for that parameter. This code accepts the array and uses the last value. Additionally, it logs a warning when this happens.
Related Issue
adobe/reactor-extension-alloy#346
https://jira.corp.adobe.com/browse/PDCL-11037
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: