Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run add-vscode-config generator on app init (retooled local debugging) #798

Merged
merged 2 commits into from Apr 30, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 26, 2024

⚠️ Note: needs https://github.com/adobe/aio-cli-plugin-app-dev installed for debugging - this new plugin should be a core plugin in the aio-cli

How Has This Been Tested?

  • npm test
  • aio app init MyApp, then running the debugger on an action (works on an app with frontend/extension, --standalone-app has this issue)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9d4bf8) to head (ab0830f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #798   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3241      3241           
  Branches       617       617           
=========================================
  Hits          3241      3241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 3e4f4f7 into master Apr 30, 2024
8 checks passed
@shazron shazron deleted the story/ACNA-2785 branch April 30, 2024 00:12
@shazron shazron restored the story/ACNA-2785 branch April 30, 2024 13:52
shazron added a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants