Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1375 - updater for runtimes.json for aio app run --local #557

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Jul 15, 2022

Description

Closes #491

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #557 (3ff3e73) into master (1189c76) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #557   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2598      2598           
  Branches       473       473           
=========================================
  Hits          2598      2598           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1189c76...3ff3e73. Read the comment docs.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but could you give me more insights on when get runtimes is called

bin/openwhisk-standalone-config/get-runtimes.js Outdated Show resolved Hide resolved
@shazron
Copy link
Member Author

shazron commented Jul 16, 2022

lgtm, but could you give me more insights on when get runtimes is called

I added a npm script that one of the team can run to update the json. This is a manual process, I'm not sure if it should be run automatic for the user (and cached) for local development, although it might be a good idea

@moritzraho
Copy link
Member

Ok do this automatically would be better, but maybe as a future step, we could open an issue ?
wdyt ?

@shazron
Copy link
Member Author

shazron commented Jul 18, 2022

Ok do this automatically would be better, but maybe as a future step, we could open an issue ? wdyt ?

yeah let's do that for the future

@shazron
Copy link
Member Author

shazron commented Jul 18, 2022

@moritzraho filed the issue for the automatic update #558

@shazron shazron merged commit ac0cd12 into master Jul 20, 2022
@shazron shazron deleted the runtimes-update branch July 20, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updater for runtimes.json for aio app run --local
2 participants