-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASSETS-33747 named smartcrop in image core v3 component #2698
Commits on Mar 17, 2024
-
ASSETS-33747 named smartcrop in image core v3 component powered by fa…
…stly (#2697) * ASSETS-33747 named smartcrop in image core v3 component powered by fastly Instead of fastly smartcrops, expect named smartcrops in delivery URLs. * ASSETS-33747 named smartcrop in image core v3 component powered by fastly Add editor code to render image through delivery URL and support smartcrop. * @trivial fix linting errors. * Show smartcrop renditions group even if DM is disabled but polaris is enabled. * Update code to also show dynamicmedia group when dialog is loaded with remote asset. * Make dependency on clientbuilderfactory optional and check for null. This is to avoid rewriting/fixing all Image test cases. * ASSETS-33747 named smartcrop in image core v3 component powered by fastly Bug fixes. * Minor bug fixes. * Fix test cases. * @trivial Fix existing test cases. * ASSETS-33747 named smartcrop in image core v3 component Review comments. Add a separate test case for smartcrop. Add a failing testcase for auto smartcrop. * ASSETS-33747 named smartcrop in image core v3 component Incorporate review feedback. * @trivial Hide the smartcrop option if remote asset does not have smartcrops. * ASSETS-33747 named smartcrop in image core v3 component Add test cases for srcset and responsehandler code. * @trivial Move the code to show smartcrop dropdown only after fetching the metadata. * @trivial Fix eslint error. --------- Co-authored-by: Levente Sántha <levente@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for c13a4ff - Browse repository at this point
Copy the full SHA c13a4ffView commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3938be1 - Browse repository at this point
Copy the full SHA 3938be1View commit details
Commits on Mar 20, 2024
-
ASSETS-33747 named smartcrop in image core v3 component
Incorporate review comments.
Configuration menu - View commit details
-
Copy full SHA for 9bade0f - Browse repository at this point
Copy the full SHA 9bade0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac5d6b6 - Browse repository at this point
Copy the full SHA ac5d6b6View commit details -
ASSETS-33747 - named smartcrop in image core v3 component
* fixed unit test failures
Configuration menu - View commit details
-
Copy full SHA for 3e5d04c - Browse repository at this point
Copy the full SHA 3e5d04cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf0fd07 - Browse repository at this point
Copy the full SHA bf0fd07View commit details -
Configuration menu - View commit details
-
Copy full SHA for f927edc - Browse repository at this point
Copy the full SHA f927edcView commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 45ca017 - Browse repository at this point
Copy the full SHA 45ca017View commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e40866f - Browse repository at this point
Copy the full SHA e40866fView commit details -
ASSETS-33747 named smartcrop in image core v3 component powered by fa…
…stly Auto smartcrop for remote assets should not depend on whether widths is configured or not.
Configuration menu - View commit details
-
Copy full SHA for 23598b4 - Browse repository at this point
Copy the full SHA 23598b4View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c19561f - Browse repository at this point
Copy the full SHA c19561fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05097a6 - Browse repository at this point
Copy the full SHA 05097a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c802fa - Browse repository at this point
Copy the full SHA 4c802faView commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1453e38 - Browse repository at this point
Copy the full SHA 1453e38View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 00b3d92 - Browse repository at this point
Copy the full SHA 00b3d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0c06f5 - Browse repository at this point
Copy the full SHA d0c06f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfed59 - Browse repository at this point
Copy the full SHA bdfed59View commit details