Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSETS-33747 named smartcrop in image core v3 component #2698

Merged
merged 17 commits into from
Apr 30, 2024

Commits on Mar 17, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component powered by fa…

    …stly (#2697)
    
    * ASSETS-33747 named smartcrop in image core v3 component powered by fastly
    
    Instead of fastly smartcrops, expect named smartcrops in delivery URLs.
    
    * ASSETS-33747 named smartcrop in image core v3 component powered by fastly
    
    Add editor code to render image through delivery URL and support smartcrop.
    
    * @trivial fix linting errors.
    
    * Show smartcrop renditions group even if DM is disabled but polaris is enabled.
    
    * Update code to also show dynamicmedia group when dialog is loaded with remote asset.
    
    * Make dependency on clientbuilderfactory optional and check for null. This is to avoid rewriting/fixing all Image test cases.
    
    * ASSETS-33747 named smartcrop in image core v3 component powered by fastly
    
    Bug fixes.
    
    * Minor bug fixes.
    
    * Fix test cases.
    
    * @trivial Fix existing test cases.
    
    * ASSETS-33747 named smartcrop in image core v3 component
    
    Review comments. Add a separate test case for smartcrop. Add a failing testcase for auto smartcrop.
    
    * ASSETS-33747 named smartcrop in image core v3 component
    
    Incorporate review feedback.
    
    * @trivial Hide the smartcrop option if remote asset does not have smartcrops.
    
    * ASSETS-33747 named smartcrop in image core v3 component
    
    Add test cases for srcset and responsehandler code.
    
    * @trivial Move the code to show smartcrop dropdown only after fetching the metadata.
    
    * @trivial Fix eslint error.
    
    ---------
    
    Co-authored-by: Levente Sántha <levente@adobe.com>
    mohiaror and LSantha committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c13a4ff View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    3938be1 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component

    Incorporate review comments.
    mohiaror committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9bade0f View commit details
    Browse the repository at this point in the history
  2. @trivial review comments.

    mohiaror committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ac5d6b6 View commit details
    Browse the repository at this point in the history
  3. ASSETS-33747 - named smartcrop in image core v3 component

     * fixed unit test failures
    LSantha committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3e5d04c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf0fd07 View commit details
    Browse the repository at this point in the history
  5. @trivial Review comments.

    mohiaror committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f927edc View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    45ca017 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    e40866f View commit details
    Browse the repository at this point in the history
  2. ASSETS-33747 named smartcrop in image core v3 component powered by fa…

    …stly
    
    Auto smartcrop for remote assets should not depend on whether widths is configured or not.
    mohiaror committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    23598b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    c19561f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05097a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c802fa View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    1453e38 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    00b3d92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0c06f5 View commit details
    Browse the repository at this point in the history
  3. @trivial fix test cases.

    mohiaror committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bdfed59 View commit details
    Browse the repository at this point in the history