Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSETS-33747 named smartcrop in image core v3 component #2676

Closed
wants to merge 20 commits into from
Closed

ASSETS-33747 named smartcrop in image core v3 component #2676

wants to merge 20 commits into from

Commits on Feb 19, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component powered by fa… 

    …stly

Instead of fastly smartcrops, expect named smartcrops in delivery URLs.
    @mohiaror
    mohiaror committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5013f08 View commit details
    Browse the repository at this point in the history

  2. ASSETS-33747 named smartcrop in image core v3 component powered by fa… 

    …stly

Add editor code to render image through delivery URL and support smartcrop.
    @mohiaror
    mohiaror committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2fa74c7 View commit details
    Browse the repository at this point in the history

  3. @trivial fix linting errors.

    @mohiaror
    mohiaror committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    59483dd View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Show smartcrop renditions group even if DM is disabled but polaris is… 

    … enabled.
    @mohiaror
    mohiaror committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7a91999 View commit details
    Browse the repository at this point in the history

  2. Update code to also show dynamicmedia group when dialog is loaded wit… 

    …h remote asset.
    @mohiaror
    mohiaror committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    db2c096 View commit details
    Browse the repository at this point in the history

  3. Make dependency on clientbuilderfactory optional and check for null. … 

    …This is to avoid rewriting/fixing all Image test cases.
    @mohiaror
    mohiaror committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c0e7c27 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component powered by fa… 

    …stly

Bug fixes.
    @mohiaror
    mohiaror committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    030d3c7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into issues/ASSETS-33747

    @mohiaror
    mohiaror committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    09bb73f View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Minor bug fixes.

    @mohiaror
    mohiaror committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2a459f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Fix test cases.

    @mohiaror
    mohiaror committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    81b271c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issues/ASSETS-33747

    @LSantha
    LSantha committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ba0ad23 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. @trivial Fix existing test cases.

    @mohiaror
    mohiaror committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    74f67c2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into issues/ASSETS-33747

    @mohiaror
    mohiaror committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1c208e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component 

    Review comments. Add a separate test case for smartcrop. Add a failing testcase for auto smartcrop.
    @mohiaror
    mohiaror committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3d052c5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into issues/ASSETS-33747

    @mohiaror
    mohiaror committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    428751c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. ASSETS-33747 named smartcrop in image core v3 component 

    Incorporate review feedback.
    @mohiaror
    mohiaror committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    675de49 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. @trivial Hide the smartcrop option if remote asset does not have smar… 

    …tcrops.
    @mohiaror
    mohiaror committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    680286c View commit details
    Browse the repository at this point in the history

  2. ASSETS-33747 named smartcrop in image core v3 component 

    Add test cases for srcset and responsehandler code.
    @mohiaror
    mohiaror committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    1e5a442 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. @trivial Move the code to show smartcrop dropdown only after fetching… 

    … the metadata.
    @mohiaror
    mohiaror committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    28361c5 View commit details
    Browse the repository at this point in the history

  2. @trivial Fix eslint error.

    @mohiaror
    mohiaror committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1566ce3 View commit details
    Browse the repository at this point in the history