-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #2526] Lazy evaluate navigation sub-items on demand #2527
base: main
Are you sure you want to change the base?
Commits on Jun 11, 2023
-
Update V1/V2
NavigationItemImpl
to use child supplierUpdates `NavigationItemImpl` constructor to accept a `Supplier` which supplies a list of children instead of passing the list its self in the constructor. This allows the work of constructing a navigation sub-tree to be deferred and only completed if the `NavigationItem#getChildren()` method is called. ---- refs adobe#2526
Configuration menu - View commit details
-
Copy full SHA for de66725 - Browse repository at this point
Copy the full SHA de66725View commit details -
Update V1/V2
NavigationImpl
to passSupplier
to item constructorsUpdates the V1 and V2 `NavigationImpl` models to pass a `Supplier` to their respective `NavigationItemImpl` constructors. Removes `Navigation#getExportedType()` because it is exactly the same as the super method. ---- refs adobe#2526
Configuration menu - View commit details
-
Copy full SHA for 7461794 - Browse repository at this point
Copy the full SHA 7461794View commit details -
Use empty list supplier for
BreadcrumbItem
children.Updates the breadcrumb model implementations by removing the `children` field from `BreadcrumbItemImpl` constructor because it is always set to empty list (i.e. breadcrumb items never have children). The `BreadcrumbItemImpl` will now pass a `Supplier` which supplies an empty list to the super class `NavigationItemImpl`. Removes `BreadcrumbImpl#getExportedType()` because it is exactly the same as the super method. ---- refs adobe#2526
Configuration menu - View commit details
-
Copy full SHA for 80baa00 - Browse repository at this point
Copy the full SHA 80baa00View commit details -
Update V1/V2
LanguageNavigationImpl
to passSupplier
to item cons……tructors Updates the V1 and V2 `LanguageNavigationImpl` models to pass a `Supplier` to their respective `LanguageNavigationItemImpl` constructors Fixes a possible NPE in `LanguageNavigationImpl` if navigation root is not set in either properties or policy. Removes `LanguageNavigationImpl#getExportedType()` because it is exactly the same as the method from the super class. Update how titles are determined for language navigation items to reuse the logic used for all other navigation items. ---- refs adobe#2526
Configuration menu - View commit details
-
Copy full SHA for 2a4cf6c - Browse repository at this point
Copy the full SHA 2a4cf6cView commit details
Commits on Sep 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9fd670b - Browse repository at this point
Copy the full SHA 9fd670bView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e46ea2a - Browse repository at this point
Copy the full SHA e46ea2aView commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9dd8bb5 - Browse repository at this point
Copy the full SHA 9dd8bb5View commit details
Commits on Apr 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d46011 - Browse repository at this point
Copy the full SHA 9d46011View commit details