Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2526] Lazy evaluate navigation sub-items on demand #2527

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Jun 11, 2023

  1. Update V1/V2 NavigationItemImpl to use child supplier

    Updates `NavigationItemImpl` constructor to accept a `Supplier` which
    supplies a list of children instead of passing the list its self in
    the constructor.
    
    This allows the work of constructing a navigation sub-tree to be
    deferred and only completed if the `NavigationItem#getChildren()`
    method is called.
    
    ----
    refs adobe#2526
    ky940819 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    de66725 View commit details
    Browse the repository at this point in the history
  2. Update V1/V2 NavigationImpl to pass Supplier to item constructors

    Updates the V1 and V2 `NavigationImpl` models to pass a `Supplier` to
    their respective `NavigationItemImpl` constructors.
    
    Removes `Navigation#getExportedType()` because it is exactly the
    same as the super method.
    
    ----
    refs adobe#2526
    ky940819 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    7461794 View commit details
    Browse the repository at this point in the history
  3. Use empty list supplier for BreadcrumbItem children.

    Updates the breadcrumb model implementations by removing the `children` field
    from `BreadcrumbItemImpl` constructor because it is always set to empty list (i.e.
    breadcrumb items never have children).
    
    The `BreadcrumbItemImpl` will now pass a `Supplier` which
    supplies an empty list to the super class `NavigationItemImpl`.
    
    Removes `BreadcrumbImpl#getExportedType()` because it is exactly the same
    as the super method.
    
    ----
    refs adobe#2526
    ky940819 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    80baa00 View commit details
    Browse the repository at this point in the history
  4. Update V1/V2 LanguageNavigationImpl to pass Supplier to item cons…

    …tructors
    
    Updates the V1 and V2 `LanguageNavigationImpl` models to pass
    a `Supplier` to their respective `LanguageNavigationItemImpl`
    constructors
    
    Fixes a possible NPE in `LanguageNavigationImpl` if
    navigation root is not set in either properties or
    policy.
    
    Removes `LanguageNavigationImpl#getExportedType()` because it
    is exactly the same as the method from the super class.
    
    Update how titles are determined for language navigation items to
    reuse the logic used for all other navigation items.
    
    ----
    refs adobe#2526
    ky940819 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    2a4cf6c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    9fd670b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    e46ea2a View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    9dd8bb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Configuration menu
    Copy the full SHA
    9d46011 View commit details
    Browse the repository at this point in the history