Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2490 log usage warning in AdaptiveImageServlet #2492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joerghoh
Copy link
Collaborator

Write a warning when the AdaptiveImageServlet is used for resizing operations. Also ensure that a log message is written if the warning has been turned off.

Q                       A
Fixed Issues? Fixes #2490
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2492 (5f0bcbd) into main (2c92898) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

❗ Current head 5f0bcbd differs from pull request most recent head 117ef36. Consider uploading reports for the commit 117ef36 to get more accurate results

@@             Coverage Diff              @@
##               main    #2492      +/-   ##
============================================
- Coverage     87.17%   87.16%   -0.02%     
- Complexity     2588     2589       +1     
============================================
  Files           229      229              
  Lines          6879     6887       +8     
  Branches       1038     1039       +1     
============================================
+ Hits           5997     6003       +6     
- Misses          356      357       +1     
- Partials        526      527       +1     
Impacted Files Coverage Δ
...onents/internal/servlets/AdaptiveImageServlet.java 78.24% <75.00%> (-0.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a warning when the AdaptiveImageServlet is not using an already eixsting renditions
1 participant