SITES-4621 Keep access to unused in between content #2261
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
=========================================
Coverage 86.94% 86.94%
- Complexity 2479 2487 +8
=========================================
Files 217 217
Lines 6634 6651 +17
Branches 1016 1020 +4
=========================================
+ Hits 5768 5783 +15
Misses 345 345
- Partials 521 523 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
herzog31
requested review from
jckautzmann,
msagolj,
Buuhuu,
LSantha and
herzog31
| import com.adobe.cq.wcm.core.components.internal.models.v1.datalayer.ContentFragmentDataImpl; | ||
| import com.adobe.cq.wcm.core.components.models.contentfragment.ContentFragment; | ||
| import com.adobe.cq.wcm.core.components.models.contentfragment.DAMContentFragment; | ||
| import com.adobe.cq.wcm.core.components.models.datalayer.ComponentData; | ||
| import com.adobe.cq.wcm.core.components.models.datalayer.ContentFragmentData; | ||
| import com.adobe.cq.wcm.core.components.models.datalayer.builder.DataLayerBuilder; | ||
| import com.adobe.cq.wcm.core.components.util.AbstractComponentImpl; |
There was a problem hiding this comment.
Could you please revert back the order of imports?
| @@ -43,6 +43,9 @@ <h3 class="cmp-contentfragment__title">${fragment.title}</h3> | |||
| ${item @ context="html"} | |||
| <div data-sly-resource="${'par{0}' @ format=itemList.count, resourceType=fragment.gridResourceType}"></div> | |||
| </div> | |||
| <div data-sly-list="${fragment.remainingInBetweenContent}"> | |||
There was a problem hiding this comment.
I think this addition should be behind an option so that we don't end up appending these where they would not be desired. IMO, it's best to have a content policy option to enable showing them.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@tyge68 hi, any updates on the task? It seems like there is still feedback open and we would like to see that functionally out of the box :) |
Fixes #1, Fixes #2Feel free to commit , reuse this code.