Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GarageWeek2021 - composable components #1906

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jckautzmann
Copy link
Contributor

@jckautzmann jckautzmann commented Dec 7, 2021

POC to create composable components (e.g. teaser is built with image, title and text components).
See discussion in #1893.

With this approach:

  • the teaser node is wrapped into a title resource (similar to the image delegation pattern)
  • the edit and design dialogs of the teaser have new tabs included from the title dialog

See also other approach in #1910.

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jckautzmann jckautzmann marked this pull request as draft December 7, 2021 15:58
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1906 (b995d26) into development (6388d22) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1906      +/-   ##
=================================================
- Coverage          86.64%   86.61%   -0.03%     
- Complexity          2293     2295       +2     
=================================================
  Files                210      210              
  Lines               6103     6112       +9     
  Branches             925      926       +1     
=================================================
+ Hits                5288     5294       +6     
- Misses               332      333       +1     
- Partials             483      485       +2     
Impacted Files Coverage Δ
...core/components/internal/models/v2/TeaserImpl.java 85.71% <62.50%> (-14.29%) ⬇️
.../core/components/internal/models/v1/TitleImpl.java 88.00% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6388d22...b995d26. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant