Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experience Fragment] XF variantion is not loaded for localized content when the fragmentVariationPath is not accesible #1517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alejokf
Copy link

@alejokf alejokf commented Apr 16, 2021

  • Avoid checking existence of the fragmentVariationPath to load the localized content even if the original path is not accessible

Fixes #1516

…onPath to load the localized content even if the original path is not accessible (adobe#1516)
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #1517 (9c9d08b) into development (11e0c6c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9c9d08b differs from pull request most recent head dcba3ce. Consider uploading reports for the commit dcba3ce to get more accurate results
Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1517      +/-   ##
=================================================
- Coverage          86.13%   86.12%   -0.01%     
+ Complexity          1973     1972       -1     
=================================================
  Files                184      184              
  Lines               5431     5428       -3     
  Branches             819      815       -4     
=================================================
- Hits                4678     4675       -3     
  Misses               306      306              
  Partials             447      447              
Impacted Files Coverage Δ Complexity Δ
...nts/internal/models/v1/ExperienceFragmentImpl.java 87.17% <ø> (-0.17%) 34.00 <0.00> (-1.00)
.../core/components/internal/models/v2/ImageImpl.java 81.81% <0.00%> (-0.14%) 41.00% <0.00%> (ø%)
.../core/components/internal/models/v1/ImageImpl.java 88.40% <0.00%> (-0.09%) 46.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e0c6c...dcba3ce. Read the comment docs.

@alejokf alejokf closed this Apr 16, 2021
@alejokf alejokf reopened this Apr 16, 2021
@alejokf alejokf closed this Apr 16, 2021
@alejokf alejokf reopened this Apr 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant