New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/1367 #1397
base: main
Are you sure you want to change the base?
Issue/1367 #1397
Conversation
c8eeae1
to
3179dc5
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
2 similar comments
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
added main js entry points for all js sites modules and added gateway main entry point for js package that can be imported as package.json 1367
…les in a main package added new components from update 2.18.0 and updated component export file issue/1367
i did update this now, get the code up to date with development and export all the additional js files that were added. We'd really appreciate support here and would love to be able to add this contribution to the code because it is very important for our component architecture that we have more flexibility in using the JS inside our application code. maybe we can get some support and feedback here @gabrielwalt @vladbailescu ? |
Kudos, SonarCloud Quality Gate passed! |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Adding exports for all js modules to ease use of core components in different FE Setups.
Adds a main.js to all core components that have a sites js client library. Requires the js files in their order and exports them. Also adds main js file for all components so the different components can be selected individually.
Usage:
add core components dependency to your package.json, e.g.
"dependencies": { "com.adobe.cq.core.wcm.components.content": "^2.13.5-SNAPSHOT" }
import the needed module in your js
import { accordion } from 'com.adobe.cq.core.wcm.components.content'; // eslint-disable-line
execute in constructor
accordion()