Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1367 #1397

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Issue/1367 #1397

wants to merge 4 commits into from

Conversation

jkoebner
Copy link
Contributor

@jkoebner jkoebner commented Feb 15, 2021

Q                       A
Fixed Issues? Fixes #1367
Patch: Bug Fix? No
Minor: New Feature? Yes
Major: Breaking Change? No
Tests Added + Pass? Not required
Documentation Provided No (code comments and or markdown)
Any Dependency Changes? No
License Apache License, Version 2.0

Adding exports for all js modules to ease use of core components in different FE Setups.
Adds a main.js to all core components that have a sites js client library. Requires the js files in their order and exports them. Also adds main js file for all components so the different components can be selected individually.

Usage:
add core components dependency to your package.json, e.g.
"dependencies": { "com.adobe.cq.core.wcm.components.content": "^2.13.5-SNAPSHOT" }
import the needed module in your js

import { accordion } from 'com.adobe.cq.core.wcm.components.content'; // eslint-disable-line

execute in constructor

accordion()

@jkoebner jkoebner changed the base branch from master to development February 15, 2021 12:36
@jkoebner jkoebner force-pushed the issue/1367 branch 2 times, most recently from c8eeae1 to 3179dc5 Compare March 3, 2021 15:14
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

2 similar comments
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

added main js entry points for all js sites modules and added gateway main entry point for js package that can be imported as package.json

1367
…les in a main package

added new components from update 2.18.0 and updated component export file

issue/1367
@jkoebner
Copy link
Contributor Author

i did update this now, get the code up to date with development and export all the additional js files that were added. We'd really appreciate support here and would love to be able to add this contribution to the code because it is very important for our component architecture that we have more flexibility in using the JS inside our application code. maybe we can get some support and feedback here @gabrielwalt @vladbailescu ?

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Core Components JS as npm modules
2 participants