Devtomaster 9 may 2024 #1229

barshat7 · 2024-05-09T11:25:11Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

Added condition on description and error message in aria-describedby

* FORMS-12203: Added localization changes and test cases * FORMS-12203: Updated test case * FORMS-12203: Altered to contains instead of get * FORMS-12203: Resolved comments * FORMS-12203: Updated test cases * FORMS-12203: Updated delete button * FORMS-12203: Updated button * Retry wizard.locale.spec.js tests * FORMS-12203: Added theme request wait * Update wizard.locale.spec.js * Added latestaddon check * Delete ui.tests/test-module/package-lock.json * Update commands.js * Revert "Delete ui.tests/test-module/package-lock.json" This reverts commit fd97b53. * Reverted package-lock.json changes * FORMS-12203: Removed exception inline * FORMS-12203: Resolved comments * FORMS-12203: Update index.js * FORMS-12203: Removed package-lock.json change * Update index.js * Update error message in index.js * Update index.js * Update wizard.locale.spec.js * Removed an intercept * Updated regex patterns --------- Co-authored-by: Shivangi Mittal <shivangim@Shivangis-MacBook-Pro.local>

@vdua

* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <vdua@adobe.com>

#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js

This reverts commit 63e3561.

…d submit() rule in examples (#1191) * FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers * FORMS-13209: updated af2 runtime version * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit() * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated submission handler test * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions * FORMS-13209: minor update --------- Co-authored-by: Arun Kumar Attri <aattri@adobe.com>

FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev

…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix

* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>

Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

…vided (#1210) * FORMS-14018 - Fix for dropdown not working when enumNames are not provided * Import fix * Improved code and test cov * Revert "Improved code and test cov" This reverts commit 7a3d69e. * Refactor for code cov * Added the removed test case

* Moving to 15860 image * updating core component version * Skipping wizard authoring test

* embedding forms-sdk api * adding hcaptcha and recaptcha models * :fix hcaptcha model SlingException * :fix deleting recaptcha model * FORMS-13811 | Adding rendition for hCaptcha * FORMS-13811 | Renamed public API * FORMS-13811 | Embedding hcaptcha js * FORMS-13811 | Adding unit test for sling model * FORMS-13811 | Adding cypress test * FORMS-13811 | Adressing review comments * Adding e2e test * FORMS-13811 | fix import statements * Update pom.xml * Adding FT for running Tests * FORMS-13811 | Removing java-8 build for master * Adding FT in test * FORMS-13811 | Tests should run only with latest addon * FORMS-13811 | Tests should run only with latest addon * increasing coverage * addressing review comments --------- Co-authored-by: Navneet Agarwal <navneeta@adobe.com>

* [FORMS-11581] Enabled Draft functionality for V2 * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Added more test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature * [FORMS-11581] Fixed test case for draft feature

…sset path in headless json (#1198) * [eds adding source property in sling model of image component to get the path in crx of the image.......] * [eds adding source property in sling model of image component to get the path in crx of the image.......] * [FORMS-13952] changed the dam repo path property to fd:repoPath * [FORMS-13952] changed the dam repo path property to fd:repoPath * fixed some test cases ........ * FORMS-13952 removed unused api of getSource... * [FORMS-13952] formatter change added in StaticImage...... --------- Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-5.macromedia.com> Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-9.corp.adobe.com>

* added changes to publish semantic html of form from container[FormContainerEds]..... * added test case to verify formDefinition api.... * added test case to verify formDefinition api.... * updated the license header of body file... * added changes to publish semantic html of form from container[FormContainerEds]..... * added test case to verify formDefinition api.... * added test case to verify formDefinition api.... * updated the license header of body file... * created a new version of page component..... * added a Utils file to move certain logic out of FormContainer sling model * made changes to remove style elements from container proxy... * made changes to remove style elements from container proxy... * removed body html from v1 of page.. * added README for page comp and bumped up minor version of the package containing form sling models.... * added java doc for the isEdgeDeliveryRequest api... * added test cases for v2 version of page component.... * added test cases for v2 version of page component.... * made suggested review changes....... --------- Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-5.macromedia.com> Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-5.corp.adobe.com> Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-9.corp.adobe.com> Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-MacBook-Pro-9.local>

add data-cmp-valid attribute for checkboxgroup and radiobutton add data-cmp-valid attribute for checkboxgroup and radiobutton add data-cmp-valid attribute for checkboxgroup and radiobutton add data-cmp-valid attribute for checkboxgroup and radiobutton

Exclude from DoR is not working for text field

Acc/space remove two

adobe-bot · 2024-05-09T11:45:56Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot · 2024-05-09T11:45:56Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot · 2024-05-09T11:46:07Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T11:47:03Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T11:47:36Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov · 2024-05-09T11:50:20Z

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.26%. Comparing base (2465443) to head (3381636).

Files	Patch %	Lines
...rms/core/components/internal/form/HtlUtilImpl.java	40.00%	1 Missing and 2 partials ⚠️
...ponents/internal/form/FormStructureParserImpl.java	81.81%	2 Missing ⚠️
...nents/internal/models/v1/form/StaticImageImpl.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1229      +/-   ##
============================================
+ Coverage     80.89%   81.26%   +0.36%     
- Complexity      791      806      +15     
============================================
  Files            92       93       +1     
  Lines          2146     2167      +21     
  Branches        292      294       +2     
============================================
+ Hits           1736     1761      +25     
+ Misses          253      252       -1     
+ Partials        157      154       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

formatting package-info.json build fix

adobe-bot · 2024-05-09T13:21:54Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot · 2024-05-09T13:21:54Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot · 2024-05-09T13:22:05Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T13:24:20Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T13:24:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T13:35:59Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot · 2024-05-09T13:35:59Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	100	75

adobe-bot · 2024-05-09T13:36:09Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T13:37:59Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-05-09T13:38:55Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

Pavitra Khatri and others added 25 commits April 16, 2024 12:13

Added condition on description and error message in aria-describedby

fae2e3a

Merge pull request #1192 from adobe/acc/err

7a326df

Added condition on description and error message in aria-describedby

FORMS-12822 : format should not be visible when no pattern is selected (

7851278

#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js

FORMS-14013 - Fixing default value check in dropdown (#1199)

63e3561

Revert "FORMS-14013 - Fixing default value check in dropdown (#1199)"

1c11f2a

This reverts commit 63e3561.

FORMS-13935 update examples for aemcomponents.dev (#1204)

ef7330d

FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev

FORMS-14013 - Testcase added - Fixing Dropdown that had a selected va…

8118d35

…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix

Forms 11746 allow attaching same file (#1201)

4995557

* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>

Read-only is not working in file-attachment (#1200)

33ddc31

Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>

Readonly & Disable were not working in TNC component (#1211)

9de36fd

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

Moving to 15860 image (#1212)

c227001

* Moving to 15860 image * updating core component version * Skipping wizard authoring test

Exclude from DoR is not working for text field in AF2

8779579

Merge pull request #1226 from adobe/textDrawDoR

40f1b66

Exclude from DoR is not working for text field

Removed space between the short desc if long desc is not present

36444a5

Refactored code of space removal in description

9536076

Merge pull request #1228 from adobe/acc/space-remove-two

995b58d

Acc/space remove two

barshat7 added 2 commits May 9, 2024 18:10

Merge branch 'master' into devtomaster-9-May-2024

686026c

formatting

3381636

formatting package-info.json build fix

barshat7 force-pushed the devtomaster-9-May-2024 branch from 7338dfc to 3381636 Compare May 9, 2024 13:10

iamsudhanshu approved these changes May 9, 2024

View reviewed changes

barshat7 merged commit 22e8c75 into master May 9, 2024
8 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devtomaster 9 may 2024 #1229

Devtomaster 9 may 2024 #1229

barshat7 commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

codecov bot commented May 9, 2024 •

edited

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

adobe-bot commented May 9, 2024

Devtomaster 9 may 2024 #1229

Devtomaster 9 may 2024 #1229

Conversation

barshat7 commented May 9, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented May 9, 2024

Lighthouse scores (desktop)

adobe-bot commented May 9, 2024

Lighthouse scores (mobile)

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

codecov bot commented May 9, 2024 • edited

Codecov Report

adobe-bot commented May 9, 2024

Lighthouse scores (desktop)

adobe-bot commented May 9, 2024

Lighthouse scores (mobile)

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Lighthouse scores (desktop)

adobe-bot commented May 9, 2024

Lighthouse scores (mobile)

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

adobe-bot commented May 9, 2024

Accessibility Violations Found

codecov bot commented May 9, 2024 •

edited