Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom function edge delivery integration #1223

Merged
merged 11 commits into from
May 22, 2024
Merged

Conversation

deepprakash345
Copy link
Contributor

No description provided.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (2b0116c) to head (e01dc88).

Files Patch % Lines
...s/internal/form/FormConfigurationProviderImpl.java 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1223      +/-   ##
============================================
+ Coverage     81.27%   81.30%   +0.02%     
- Complexity      807      812       +5     
============================================
  Files            93       94       +1     
  Lines          2168     2182      +14     
  Branches        294      298       +4     
============================================
+ Hits           1762     1774      +12     
  Misses          252      252              
- Partials        154      156       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@rismehta
Copy link
Collaborator

the patch coverage is less, please fix the coverage

@github-actions github-actions bot force-pushed the customFunctionEdgeDelivery branch from 168a243 to e283925 Compare May 14, 2024 09:06
@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 98 96 96 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@deepprakash345
Copy link
Contributor Author

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM

@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines.

@jalagari
Copy link
Contributor

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM @rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the **ifs** as partial lines.

@deepprakash345 - Can we add unit test cases for missing cases?

Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the FT present in the test case, dependent on the feature which is part of this PR ? If not, please remove these from the CL

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 100 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@deepprakash345
Copy link
Contributor Author

Are the FT present in the test case, dependent on the feature which is part of this PR ? If not, please remove these from the CL

removed

@deepprakash345
Copy link
Contributor Author

the patch coverage is less, please fix the coverage

Screenshot 2024-05-21 at 9 40 47 AM @rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the **ifs** as partial lines.

@deepprakash345 - Can we add unit test cases for missing cases?

added UTs , coverage check passed.

@deepprakash345
Copy link
Contributor Author

@rismehta , @jalagari please check

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

2 similar comments
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@rismehta rismehta dismissed arunattri26’s stale review May 22, 2024 06:30

Comments incorporated

@rismehta rismehta merged commit 74e7d4c into dev May 22, 2024
9 of 10 checks passed
@rismehta rismehta deleted the customFunctionEdgeDelivery branch May 22, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants