-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom function edge delivery integration #1223
Conversation
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1223 +/- ##
============================================
+ Coverage 81.27% 81.30% +0.02%
- Complexity 807 812 +5
============================================
Files 93 94 +1
Lines 2168 2182 +14
Branches 294 298 +4
============================================
+ Hits 1762 1774 +12
Misses 252 252
- Partials 154 156 +2 ☔ View full report in Codecov by Sentry. |
...content/jcr_root/apps/core/fd/components/form/container/v2/container/_cq_dialog/.content.xml
Show resolved
Hide resolved
...src/main/content/jcr_root/apps/core/fd/components/form/container/v2/container/container.html
Outdated
Show resolved
Hide resolved
...ain/java/com/adobe/cq/forms/core/components/internal/form/FormConfigurationProviderImpl.java
Outdated
Show resolved
Hide resolved
...ain/java/com/adobe/cq/forms/core/components/internal/form/FormConfigurationProviderImpl.java
Show resolved
Hide resolved
...ain/java/com/adobe/cq/forms/core/components/internal/form/FormConfigurationProviderImpl.java
Outdated
Show resolved
Hide resolved
ui.tests/test-module/specs/customfunctionedgedelivery/customfunctionedgedelivery.spec.js
Show resolved
Hide resolved
...src/main/content/jcr_root/apps/core/fd/components/form/container/v2/container/container.html
Show resolved
Hide resolved
.../src/main/java/com/adobe/cq/forms/core/components/models/form/FormConfigurationProvider.java
Show resolved
Hide resolved
.../src/main/java/com/adobe/cq/forms/core/components/models/form/FormConfigurationProvider.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comments
the patch coverage is less, please fix the coverage |
168a243
to
e283925
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the ifs as partial lines. |
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the **ifs** as partial lines. @deepprakash345 - Can we add unit test cases for missing cases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the FT present in the test case, dependent on the feature which is part of this PR ? If not, please remove these from the CL
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
removed |
@rismehta , as seen in the screenshot of the codecov, all the branches of the code are covered, its showing the **ifs** as partial lines. added UTs , coverage check passed. |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
No description provided.