Custom function test cases #1206

deepprakash345 · 2024-04-25T06:25:06Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

adobe-bot · 2024-04-25T06:48:17Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2024-04-25T06:48:17Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot · 2024-04-25T06:48:29Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-04-25T06:48:53Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2024-04-25T06:48:54Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov · 2024-04-25T06:50:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (86fff6f) to head (c28d102).

❗ Current head c28d102 differs from pull request most recent head b1aa879. Consider uploading reports for the commit b1aa879 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##                eds    #1206   +/-   ##
=========================================
  Coverage     80.29%   80.29%           
  Complexity      777      777           
=========================================
  Files            92       92           
  Lines          2136     2136           
  Branches        289      289           
=========================================
  Hits           1715     1715           
  Misses          263      263           
  Partials        158      158

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rismehta · 2024-05-02T09:17:39Z

ui.tests/test-module/specs/customfunctionedgedelivery/customfunctionedgedelivery.spec.js

+    it(" fullName field should update on change in first name and last name ", () => {
+        if(toggle_array.includes("FT_FORMS-11269") && toggle_array.includes("FT_FORMS-12423")) {
+            Cypress.config('chromeWebSecurity',false);
+            console.log("cypress security is "+Cypress.config('chromeWebSecurity'));


Why are we turning off chromeWebSecurity? Ideally, our tests should mimic real-world scenarios. We should be enabling CORS headers in the URL that serves custom functions.

rismehta

check comments

@vdua

@review @vdua DOD(Yes)

* disable exposing view layer for customization * adding dam asset for test cases * disable exposing view layer for customization: fixed test cases

* Invalid event customization * Adding invalid event * Updating af-core version

* CQ-4348557 adding another div to stop footer getting resized * CQ-4348557 removing space --------- Co-authored-by: Shivam Agarwal <shivama@adobe.com>

#1158) * FORMS-13810: Add the field to allow custom message for format in date picker * FORMS-13810: Test case added * FORMS-13810: Review comments incorporated.

…ted. (#1164)

Co-authored-by: dgurjar <dgurjar@adobe.com>

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

Co-authored-by: Shivam Agarwal <shivama@adobe.com>

) * datepicker readonly does not work when edit or display format set * Update datepicker.runtime.spec.js --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>

…group (#1176) * Update type property on replacing checkboxgroup to radio group * FORMS-12667 review comment --------- Co-authored-by: demaurya <demaurya@adobe.com>

@vdua

@review @vdua DOD(Yes)

* Move core component to 0.13.0 spec version - RTC (done) DOD(yes) * Move core component to 0.13.0 spec version - RTC (done) DOD(yes) * Fixing wrong date picker test case * Fixing date picker test case

* datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed * datepicker fix test case

* Updating spec version to 0.13.0 * Updating spec version to 0.13.0 * Updating spec version to 0.13.0

* FORMS-12203: Added localization changes and test cases * FORMS-12203: Updated test case * FORMS-12203: Altered to contains instead of get * FORMS-12203: Resolved comments * FORMS-12203: Updated test cases * FORMS-12203: Updated delete button * FORMS-12203: Updated button * Retry wizard.locale.spec.js tests * FORMS-12203: Added theme request wait * Update wizard.locale.spec.js * Added latestaddon check * Delete ui.tests/test-module/package-lock.json * Update commands.js * Revert "Delete ui.tests/test-module/package-lock.json" This reverts commit fd97b53. * Reverted package-lock.json changes * FORMS-12203: Removed exception inline * FORMS-12203: Resolved comments * FORMS-12203: Update index.js * FORMS-12203: Removed package-lock.json change * Update index.js * Update error message in index.js * Update index.js * Update wizard.locale.spec.js * Removed an intercept * Updated regex patterns --------- Co-authored-by: Shivangi Mittal <shivangim@Shivangis-MacBook-Pro.local>

@vdua

* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <vdua@adobe.com>

#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js

This reverts commit 63e3561.

…d submit() rule in examples (#1191) * FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers * FORMS-13209: updated af2 runtime version * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit() * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated submission handler test * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions * FORMS-13209: minor update --------- Co-authored-by: Arun Kumar Attri <aattri@adobe.com>

FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev

…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix

* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>

Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

…vided (#1210) * FORMS-14018 - Fix for dropdown not working when enumNames are not provided * Import fix * Improved code and test cov * Revert "Improved code and test cov" This reverts commit 7a3d69e. * Refactor for code cov * Added the removed test case

* Moving to 15860 image * updating core component version * Skipping wizard authoring test

* embedding forms-sdk api * adding hcaptcha and recaptcha models * :fix hcaptcha model SlingException * :fix deleting recaptcha model * FORMS-13811 | Adding rendition for hCaptcha * FORMS-13811 | Renamed public API * FORMS-13811 | Embedding hcaptcha js * FORMS-13811 | Adding unit test for sling model * FORMS-13811 | Adding cypress test * FORMS-13811 | Adressing review comments * Adding e2e test * FORMS-13811 | fix import statements * Update pom.xml * Adding FT for running Tests * FORMS-13811 | Removing java-8 build for master * Adding FT in test * FORMS-13811 | Tests should run only with latest addon * FORMS-13811 | Tests should run only with latest addon * increasing coverage * addressing review comments --------- Co-authored-by: Navneet Agarwal <navneeta@adobe.com>

Deep Prakash Dewanji added 2 commits April 25, 2024 11:54

added tests for customFunctionsEdgeDelivery

b5f4c72

changed edge delivery config for test cases

c28d102

deepprakash345 requested review from jalagari and rismehta April 25, 2024 06:25

rismehta reviewed May 2, 2024

View reviewed changes

rismehta requested changes May 2, 2024

View reviewed changes

rismehta and others added 18 commits May 7, 2024 03:44

FORMS-13753 Fixing regression related to dataRef parameter (#1155)

3c8a133

@review @vdua DOD(Yes)

disable exposing view layer for customization (#1156)

55a0bcf

* disable exposing view layer for customization * adding dam asset for test cases * disable exposing view layer for customization: fixed test cases

FORMS-13484: Update the help link for Embed (v2) (#1154)

8530b50

Invalid event customization (#1157)

dfe32c5

* Invalid event customization * Adding invalid event * Updating af-core version

CQ-4348557 adding another div to stop footer getting resized (#1122)

a1a8555

* CQ-4348557 adding another div to stop footer getting resized * CQ-4348557 removing space --------- Co-authored-by: Shivam Agarwal <shivama@adobe.com>

FORMS-13810: Add the field to allow custom message for format in date… (

eca9cc9

#1158) * FORMS-13810: Add the field to allow custom message for format in date picker * FORMS-13810: Test case added * FORMS-13810: Review comments incorporated.

FORMS-13829 Drop Down View not getting updated, even if model is upda…

2b89ab0

…ted. (#1164)

fixed issue for Persian language (#1162)

5d1e1a4

Co-authored-by: dgurjar <dgurjar@adobe.com>

Added Aria Invalid attribute (#1149)

2532f2d

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

FORMS-13871 text shouldn't show checkbox for rich text title (#1173)

4ba0e6d

Co-authored-by: Shivam Agarwal <shivama@adobe.com>

datepicker readonly does not work when edit or display format set (#1171

f059101

) * datepicker readonly does not work when edit or display format set * Update datepicker.runtime.spec.js --------- Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>

FORMS-12667 Update type property on replacing checkboxgroup to radio …

77544d7

…group (#1176) * Update type property on replacing checkboxgroup to radio group * FORMS-12667 review comment --------- Co-authored-by: demaurya <demaurya@adobe.com>

FORMS-13760 Date picker display value not working during prefill (#1180)

7a3862d

@review @vdua DOD(Yes)

Move core component to 0.13.0 spec version (#1181)

ad32b54

* Move core component to 0.13.0 spec version - RTC (done) DOD(yes) * Move core component to 0.13.0 spec version - RTC (done) DOD(yes) * Fixing wrong date picker test case * Fixing date picker test case

datepicker timezone issue on view layer fixed (#1168)

3f2eb05

* datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed * datepicker fix test case

Updating spec version to 0.13.0 (#1186)

556a100

* Updating spec version to 0.13.0 * Updating spec version to 0.13.0 * Updating spec version to 0.13.0

Added condition on description and error message in aria-describedby

82a2a68

rismehta and others added 13 commits May 7, 2024 03:44

FORMS-12822 : format should not be visible when no pattern is selected (

3d5e173

#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js

FORMS-14013 - Fixing default value check in dropdown (#1199)

7e90adb

Revert "FORMS-14013 - Fixing default value check in dropdown (#1199)"

ef0453b

This reverts commit 63e3561.

FORMS-13935 update examples for aemcomponents.dev (#1204)

c707a57

FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev

FORMS-14013 - Testcase added - Fixing Dropdown that had a selected va…

2db297c

…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix

Forms 11746 allow attaching same file (#1201)

bc2bea4

* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>

Read-only is not working in file-attachment (#1200)

64e76c1

Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>

Readonly & Disable were not working in TNC component (#1211)

d528c58

Co-authored-by: Pavitra Khatri <pavitrakhatri@Pavitras-MacBook-Pro.local>

Moving to 15860 image (#1212)

1947221

* Moving to 15860 image * updating core component version * Skipping wizard authoring test

github-actions bot force-pushed the customFunctionTestCases branch from be8dc79 to b1aa879 Compare May 7, 2024 03:44

deepprakash345 closed this May 7, 2024

deepprakash345 deleted the customFunctionTestCases branch May 7, 2024 03:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom function test cases #1206

Custom function test cases #1206

deepprakash345 commented Apr 25, 2024

adobe-bot commented Apr 25, 2024

adobe-bot commented Apr 25, 2024

adobe-bot commented Apr 25, 2024

adobe-bot commented Apr 25, 2024

adobe-bot commented Apr 25, 2024

codecov bot commented Apr 25, 2024 •

edited

rismehta May 2, 2024

rismehta left a comment

Custom function test cases #1206

Custom function test cases #1206

Conversation

deepprakash345 commented Apr 25, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented Apr 25, 2024

Lighthouse scores (desktop)

adobe-bot commented Apr 25, 2024

Lighthouse scores (mobile)

adobe-bot commented Apr 25, 2024

Accessibility Violations Found

adobe-bot commented Apr 25, 2024

Accessibility Violations Found

adobe-bot commented Apr 25, 2024

Accessibility Violations Found

codecov bot commented Apr 25, 2024 • edited

Codecov Report

rismehta May 2, 2024

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 25, 2024 •

edited