Forms 11746 allow attaching same file #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
FORMS-11746-allow_attaching_same_file
branch
from
a27a742
to
7846c9a
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1201 +/- ##
=========================================
Coverage 80.81% 80.81%
Complexity 782 782
=========================================
Files 91 91
Lines 2116 2116
Branches 286 286
=========================================
Hits 1710 1710
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Apr 23, 2024
| cy.get(".cmp-adaptiveform-fileinput__filename").contains(sampleFileName); | ||
| cy.get(fileInput).should(($element) => { | ||
| const actualValue = $element.val(); | ||
| expect(actualValue.includes("")).to.be.true; |
There was a problem hiding this comment.
Why we are checking for empty value inside actual value ? Is this relevant
There was a problem hiding this comment.
Its because we are clearing the value once the file is attached so that duplicate file can be attached and also I have added the test case to attach the duplicate file.
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
* updated code for ui.frontend with test cases * resolved PR comments * test case fixed --------- Co-authored-by: Gulshan Mishra <gulshanm@adobe.com> Co-authored-by: Rajat Khurana <rajatkhurana@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: