adding source property in sling model of image component to get dam asset path in headless json #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the path in crx of the image.......]
rismehta
reviewed
Apr 22, 2024
| "visible": false, | ||
| "altText": "abc", | ||
| "value": "/content/image-customized.img.png", | ||
| "source": "/content/image-customized.img.png", |
There was a problem hiding this comment.
The schema validation test case would also fail because you have added a new property for image field type. However, ideally, we should also review and possibly update the specification for source/value property name. Can you start a conversation on our internal Slack channel to finalize the property name? In my opinion, the source should be a custom property that points to the DAM image, given that this detail is specific to AEM. The specification should mandate only a single property for an image, which is its URL (whether the property name should be value or source, we need to decide the same, but only one property should be enforce by spec)
…the path in crx of the image.......]
github-actions
bot
force-pushed
the
FORMS-13952
branch
from
b4e86cf
to
f950658
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1198 +/- ##
============================================
- Coverage 80.89% 80.88% -0.02%
- Complexity 791 793 +2
============================================
Files 92 92
Lines 2146 2150 +4
Branches 292 293 +1
============================================
+ Hits 1736 1739 +3
Misses 253 253
- Partials 157 158 +1 ☔ View full report in Codecov by Sentry. |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
May 7, 2024
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/models/form/StaticImage.java
Outdated
Show resolved
Hide resolved
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.